Skip to content

/ webtorrent

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Magnet Player to FAQ #918

Merged
merged 1 commit into from Sep 18, 2016
Merged

Adds Magnet Player to FAQ #918

merged 1 commit into from Sep 18, 2016
+3 −0

Conversation

@ferrolho
Copy link
Contributor

ferrolho commented Sep 18, 2016

No description provided.

@ferrolho
Adds Magnet Player to FAQ
Loading status checks…
f81fbd6
@DiegoRBaquero
DiegoRBaquero approved these changes Sep 18, 2016
View changes
Copy link
Member

DiegoRBaquero left a comment

LGTM. I'm amazed that you changed everything so quick. I'll let feross merge this one
@ferrolho

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

ferrolho commented Sep 18, 2016

Ahah! :P I want to finish this so I can start other projects, @DiegoRBaquero. Yes, let's wait for feross' approval.
@DiegoRBaquero

This comment has been minimized.

Sign in to view
Copy link
Member

DiegoRBaquero commented Sep 18, 2016

@ferrolho What else are you working on? I'm looking for new projects to work on too
@ferrolho

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

ferrolho commented Sep 18, 2016

@DiegoRBaquero Nothing at the moment.. Classes start this Monday, so I guess I don't have much time left :(
@dcposch
dcposch approved these changes Sep 18, 2016
View changes
Copy link
Contributor

dcposch left a comment

Nice web design!

Nitpick here, but I recommend using up and down arrows instead of diagonal ones.

Before

screen shot 2016-09-17 at 9 30 09 pm

After

screen shot 2016-09-17 at 9 32 29 pm
@dcposch dcposch merged commit 0e3bdd5 into webtorrent:master Sep 18, 2016
3 checks passed
3 checks passed
Node Security No known vulnerabilities found
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ferrolho

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

ferrolho commented Sep 18, 2016

@dcposch Thanks for the tip! I have changed it and I like it much better now :)
@lock

This comment has been minimized.

Sign in to view
Copy link

lock bot commented May 4, 2018

This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue.
@lock lock bot locked as resolved and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dcposch dcposch

@DiegoRBaquero DiegoRBaquero

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@ferrolho @DiegoRBaquero @dcposch
You can’t perform that action at this time.