Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seed: allow announce field with trackers disabled #928

Merged
merged 1 commit into from Sep 27, 2016
Merged

Seed: allow announce field with trackers disabled #928

merged 1 commit into from Sep 27, 2016

Conversation

@dcposch
Copy link
Contributor

dcposch commented Sep 20, 2016

Creating a WebTorrent client with the {tracker: false} option means it doesn't talk to trackers -- only (potentially) the DHT and web seeds.

However, creating a torrent using .seed() should still work normally, and the resulting torrent's announce field should be the same as it would normally be.

@dcposch

This comment has been minimized.

Copy link
Contributor Author

dcposch commented Sep 20, 2016

@feross thoughts?

@dcposch

This comment has been minimized.

Copy link
Contributor Author

dcposch commented Sep 26, 2016

What does this error mean?

1..170
# tests 170
# pass  170
# ok
events.js:160
      throw er; // Unhandled 'error' event
      ^
Error: connection refused: localtunnel.me:36746 (check your firewall settings)
    at Socket.<anonymous> (/home/travis/build/feross/webtorrent/node_modules/localtunnel/client.js:84:32)
    at emitOne (events.js:96:13)
    at Socket.emit (events.js:188:7)
    at emitErrorNT (net.js:1271:8)
    at _combinedTickCallback (internal/process/next_tick.js:74:11)
    at process._tickCallback (internal/process/next_tick.js:98:9)
npm ERR! Linux 3.13.0-40-generic
npm ERR! argv "/home/travis/.nvm/versions/node/v6.6.0/bin/node" "/home/travis/.nvm/versions/node/v6.6.0/bin/npm" "run" "test-browser"
npm ERR! node v6.6.0
npm ERR! npm  v3.10.3
npm ERR! code ELIFECYCLE
npm ERR! webtorrent@0.97.1 test-browser: `zuul -- test/*.js test/browser/*.js`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the webtorrent@0.97.1 test-browser script 'zuul -- test/*.js test/browser/*.js'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the webtorrent package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     zuul -- test/*.js test/browser/*.js
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs webtorrent
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls webtorrent
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     /home/travis/build/feross/webtorrent/npm-debug.log
npm ERR! Test failed.  See above for more details.
The command "npm test" exited with 1.

Tests pass in Node but fail in the browser (zuul).

@feross
feross approved these changes Sep 27, 2016
@@ -98,7 +99,7 @@ test('client.seed: filesystem path to folder with one file, string', function (t
client.on('error', function (err) { t.fail(err) })
client.on('warning', function (err) { t.fail(err) })

client.seed(fixtures.folder.contentPath, function (torrent) {
client.seed(fixtures.folder.contentPath, {announce: false}, function (torrent) {

This comment has been minimized.

Copy link
@feross

feross Sep 27, 2016

Member

Why are you using false and [] inconsistently?

@feross

This comment has been minimized.

Copy link
Member

feross commented Sep 27, 2016

What does this error mean?

It's just the tunnel server crashing, which happens unfortunately often. Not your fault.

@feross feross merged commit d62778e into master Sep 27, 2016
3 of 5 checks passed
3 of 5 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
Node Security No known vulnerabilities found
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@feross feross deleted the web-seeds branch Sep 27, 2016
@lock

This comment has been minimized.

Copy link

lock bot commented May 4, 2018

This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue.

@lock lock bot locked as resolved and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.