Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upSeed: allow announce field with trackers disabled #928
Conversation
This comment has been minimized.
This comment has been minimized.
|
@feross thoughts? |
This comment has been minimized.
This comment has been minimized.
|
What does this error mean?
Tests pass in Node but fail in the browser (zuul). |
This was referenced Sep 26, 2016
| @@ -98,7 +99,7 @@ test('client.seed: filesystem path to folder with one file, string', function (t | |||
| client.on('error', function (err) { t.fail(err) }) | |||
| client.on('warning', function (err) { t.fail(err) }) | |||
|
|
|||
| client.seed(fixtures.folder.contentPath, function (torrent) { | |||
| client.seed(fixtures.folder.contentPath, {announce: false}, function (torrent) { | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
It's just the tunnel server crashing, which happens unfortunately often. Not your fault. |
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
May 4, 2018
|
This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
dcposch commentedSep 20, 2016
Creating a WebTorrent client with the
{tracker: false}option means it doesn't talk to trackers -- only (potentially) the DHT and web seeds.However, creating a torrent using
.seed()should still work normally, and the resulting torrent'sannouncefield should be the same as it would normally be.