Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upInitialize WRTC #937
Merged
Initialize WRTC #937
Conversation
| @@ -101,9 +101,10 @@ function WebTorrent (opts) { | |||
| if (opts.wrtc) { | |||
| // TODO: remove in v1 | |||
| console.warn('WebTorrent: opts.wrtc is deprecated. Use opts.tracker.wrtc instead') | |||
| self.tracker.wrtc = opts.wrtc // to support `webtorrent-hybrid` package | |||
| self.tracker.wrtc = opts.wrtc | |||
This comment has been minimized.
This comment has been minimized.
feross
Oct 4, 2016
Member
Good call removing this comment -- this option can be used by any package, not just webtorrent-hybrid :)
This comment has been minimized.
This comment has been minimized.
|
Actually, I think this belongs in |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
May 4, 2018
|
This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
DiegoRBaquero commentedOct 3, 2016
•
edited
If the global WRTC variable is a function then call it to initialize it.
Related: