Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upDon't run Electron tests on Travis #947
Closed
Conversation
This comment has been minimized.
This comment has been minimized.
|
Disregard, there's a better way to fix it. See the following: |
This comment has been minimized.
This comment has been minimized.
|
Thanks for doing this workaround, but I made a real fix here: #949 |
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
May 4, 2018
|
This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
josephfrazier commentedOct 12, 2016
This is a workaround for #945
Note that pull requests from other repos will still run the Electron
tests (and remind us that it's broken), but at least master will be
green again.