Skip to content

/ webtorrent

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix xvfb on Travis #948

Merged
merged 1 commit into from Oct 12, 2016
Merged

Fix xvfb on Travis #948

merged 1 commit into from Oct 12, 2016

Conversation

@josephfrazier
Copy link
Member

josephfrazier commented Oct 12, 2016

Fixes #945

Adapted from 1013b5b
@josephfrazier
Fix xvfb on Travis
Loading status checks…
6b4f073
@feross
feross approved these changes Oct 12, 2016
View changes
Copy link
Member

feross left a comment

👍
@feross feross merged commit 7371b3c into webtorrent:master Oct 12, 2016
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
Node Security No known vulnerabilities found
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@josephfrazier

This comment has been minimized.

Sign in to view
Copy link
Member Author

josephfrazier commented Oct 12, 2016

Hmm, now it seems like Travis is just flaky, given that master is currently equivalent to commit 6b4f073 above...

master: https://travis-ci.org/feross/webtorrent/builds/167193572#L1832
6b4f073: https://travis-ci.org/feross/webtorrent/builds/167173908#L1835
@feross

This comment has been minimized.

Sign in to view
Copy link
Member

feross commented Oct 12, 2016

I just tried changing electron to electron-prebuilt and re-ran the build 5 times. All passed.

Looks like there was some change between electron pre-1.0 and latest 1.x that is causing a race condition. Maybe the timing of some event changed and zuul needs to be updated? :shrug:
@josephfrazier josephfrazier deleted the josephfrazier:travis-xvfb branch Oct 13, 2016
@lock

This comment has been minimized.

Sign in to view
Copy link

lock bot commented May 4, 2018

This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue.
@lock lock bot locked as resolved and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@feross feross

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@josephfrazier @feross
You can’t perform that action at this time.