Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upadd 'user-agent' option #961
Conversation
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "name": "webtorrent", | |||
| "description": "Streaming torrent client", | |||
| "version": "0.97.2", | |||
| "version": "0.97.3", | |||
This comment has been minimized.
This comment has been minimized.
josephfrazier
Oct 30, 2016
Member
I don't know enough about #962 to comment on the rest of the changes, but I don't think package.json should be changed here. If you look at the file's history, you'll see that the version is incremented separately from other changes when there is a new release.
This comment has been minimized.
This comment has been minimized.
zunsthy
Nov 6, 2016
Author
i'm sorry that and reverted package.json just now. thanks for your suggest : )
This comment has been minimized.
This comment has been minimized.
|
Let's set the user agent, but I don't think we want it to be configuration by the end-user since the implementation that's that making the requests ought to be identifiable IMO. This still fixes the issue of there being no user agent: #962 |
This comment has been minimized.
This comment has been minimized.
|
This PR is superseded by #1019 |
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
May 4, 2018
|
This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue. |
zunsthy commentedOct 28, 2016
•
edited
#962