Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 'user-agent' option #961

Closed
wants to merge 3 commits into from
Closed
Changes from 1 commit
Commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

Next

add 'use-agent' option

  • Loading branch information
zunsthy committed Oct 28, 2016
commit edcb237a03c83d2837813abef2fcd62295e052a0
@@ -78,6 +78,12 @@ function WebTorrent (opts) {
}
self.nodeIdBuffer = Buffer.from(self.nodeId, 'hex')

if (typeof opts.userAgent === 'string') {
self.userAgent = opts.userAgent
} else {
self.userAgent = 'WebTorrent/' + VERSION + ' (https://webtorrent.io)'
}

self.destroyed = false
self.listening = false
self.torrentPort = opts.torrentPort || 0
@@ -330,6 +330,7 @@ Torrent.prototype._onListening = function () {
infoHash: self.infoHash,
announce: self.announce,
peerId: self.client.peerId,
userAgent: self.client.userAgent,
dht: !self.private && self.client.dht,
tracker: trackerOpts,
port: self.client.torrentPort
@@ -1,7 +1,7 @@
{
"name": "webtorrent",
"description": "Streaming torrent client",
"version": "0.97.2",
"version": "0.97.3",

This comment has been minimized.

Copy link
@josephfrazier

josephfrazier Oct 30, 2016

Member

I don't know enough about #962 to comment on the rest of the changes, but I don't think package.json should be changed here. If you look at the file's history, you'll see that the version is incremented separately from other changes when there is a new release.

This comment has been minimized.

Copy link
@zunsthy

zunsthy Nov 6, 2016

Author

i'm sorry that and reverted package.json just now. thanks for your suggest : )

"author": {
"name": "WebTorrent, LLC",
"email": "feross@webtorrent.io",
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.