Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAdding property for downloaded bytes per file. #974
Merged
Conversation
|
LGTM. Would be great if you could add tests. |
This comment has been minimized.
This comment has been minimized.
|
Is this going to get merged soon or should I deploy with a fork for a while until it is? |
vankasteelj left a comment
|
Tested, working as it should |
|
LGTM, but missing tests and doc changes. I'll add for you this time. |
This comment has been minimized.
This comment has been minimized.
|
Released as 0.98.0. Sorry for the delay. |
This comment has been minimized.
This comment has been minimized.
vankasteelj
commented
Nov 23, 2016
|
Awesome, thanks |
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
May 4, 2018
|
This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mikeal commentedNov 10, 2016
Needed this in an app I've been building. It's almost the same as the property on the full torrent.