-
Notifications
You must be signed in to change notification settings - Fork 1k
add nim bindings for webview #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@oskca Thank you! I would really love to merge it, but have to solve a few other related things first. Btw, I had a small talk with the author of Nimble at FOSDEM, he is aware of the issue with Meanwhile, I am working on Python and Node.js bindings, and they both require to copy webview.h into the bindings subfolder and in general I'm trying to figure out how to handle various bindings under one repo. Once I settle this up - I will comment on this PR and most likely the directory structure is likely to be changed, but I'm not sure yet. Anyway, thank you for the contributions, and I hope I didn't scare you away :) |
|
No problem 😄 BTW, It's great that you talk to @dom96 personally about the |
* Make "skip to C/C++ section" a link * Fix broken link to iconverticons.com * Use `backticks` to be consistent with the sh-style `$` prompt in the Linux build instructions (`$(shell ...)` is Makefile syntax) * Remove typo in designated initializer (.resizable repeated) * Some minor grammar fixes
* python: initial bindings * webview: add c++ tests
|
In case you guys haven't noticed, the issue has been solved :) |
|
Great, I'll check it soon |
|
@zserge I've put the nim bindings into the sub directory: bindings, can you check this pull request again 😄 |
|
@dom96 I'll change the nimble url as soon as the pull request is accepted 😄 |
|
This this has been moved to https://github.com/oskca/webview, I'll close the PR. |
No description provided.