Skip to content

Conversation

oskca
Copy link

@oskca oskca commented Feb 21, 2018

No description provided.

@zserge
Copy link
Collaborator

zserge commented Feb 21, 2018

@oskca Thank you! I would really love to merge it, but have to solve a few other related things first.

Btw, I had a small talk with the author of Nimble at FOSDEM, he is aware of the issue with .nimble files in the repo root and he is willing to fix it soon, so hoping for the best.

Meanwhile, I am working on Python and Node.js bindings, and they both require to copy webview.h into the bindings subfolder and in general I'm trying to figure out how to handle various bindings under one repo.

Once I settle this up - I will comment on this PR and most likely the directory structure is likely to be changed, but I'm not sure yet.

Anyway, thank you for the contributions, and I hope I didn't scare you away :)

@oskca
Copy link
Author

oskca commented Feb 22, 2018

No problem 😄

BTW, It's great that you talk to @dom96 personally about the .nimble issue, and I hope there's a solution very soon 👍

walfie and others added 11 commits March 7, 2018 09:00
* Make "skip to C/C++ section" a link
* Fix broken link to iconverticons.com
* Use `backticks` to be consistent with the sh-style `$` prompt in
  the Linux build instructions (`$(shell ...)` is Makefile syntax)
* Remove typo in designated initializer (.resizable repeated)
* Some minor grammar fixes
* python: initial bindings

* webview: add c++ tests
@dom96
Copy link

dom96 commented Apr 5, 2018

In case you guys haven't noticed, the issue has been solved :)

@oskca
Copy link
Author

oskca commented Apr 6, 2018

Great, I'll check it soon

@oskca
Copy link
Author

oskca commented Apr 6, 2018

@zserge I've put the nim bindings into the sub directory: bindings, can you check this pull request again 😄

@oskca
Copy link
Author

oskca commented Apr 6, 2018

@dom96 I'll change the nimble url as soon as the pull request is accepted 😄

@zserge
Copy link
Collaborator

zserge commented Jan 8, 2020

This this has been moved to https://github.com/oskca/webview, I'll close the PR.

@zserge zserge closed this Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants