Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix for mailsetting - bnc#784360 & bnc#791787 #23

Merged
merged 11 commits into from Jan 4, 2013

Conversation

Projects
None yet
3 participants
Contributor

vmoravec commented Dec 20, 2012

  • Sending of test email fixed
  • Added validation of model
  • Some typo and formatting fixed

lslezak added a commit that referenced this pull request Jan 4, 2013

Merge pull request #23 from vmoravec/mailsetting-fix
Fix for mailsetting - bnc#784360 & bnc#791787

Review Ok

@lslezak lslezak merged commit ce7ae5b into webyast:master Jan 4, 2013

@kobliha kobliha commented on the diff Jan 7, 2013

plugins/mailsetting/app/views/mailsetting/show.html.erb
@@ -84,29 +83,29 @@
<div class="fieldset_body">
<div class="row">
- <label for="<%= :smtp_server %>"><%=_("Outgoing mail server")%></label>
+ <label style="float:left" for="<%= :smtp_server %>"><%=_("Outgoing mail server")%></label>
<%=f.text_field :smtp_server, :disabled => disabled, :class => "smtp_server tipsy_help", :title => _("URL of the outgoing mail server. You may also specify an alternate port number, e.g.
relay.example.com:26. Use square brackets around the host name to prevent from DNS MX lookups.") %>
@kobliha

kobliha Jan 7, 2013

Contributor

Just an idea. It could be useful if you've written an example of what is summarized here: square brackets around hostname (with/without port number).

@vmoravec vmoravec deleted the vmoravec:mailsetting-fix branch Jan 7, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment