Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

first item of memberList as owner is confusion #358

Merged
merged 2 commits into from Mar 24, 2017
Merged

first item of memberList as owner is confusion #358

merged 2 commits into from Mar 24, 2017

Conversation

JasLin
Copy link
Contributor

@JasLin JasLin commented Mar 24, 2017

  1. in wxwebapp,first item in memberList is a random user from the room ,it's confusion,
  2. some times we can got owneruin or ChatRoomOwner .

as those reason, first member from memberlist should not be here any more

JasLin and others added 2 commits March 24, 2017 17:13
@JasLin
Merge pull request #5 from Chatie/master
62dc38b 
upgrade to  latest code
1. in wxwebapp,first item in memberList is a random user from the roo…
22d6c39 
…m, 2. some times we can got owneruin or ChatRoomOwner . as those reason, first member from memberlist should not be here any more
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 56.496% when pulling 22d6c39 on JasLin:master into f76d72c on Chatie:master.

@huan
Copy link
Member

huan commented Mar 24, 2017

Thanks bro, you are right.

@huan huan merged commit 88f9833 into wechaty:master Mar 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JasLin @coveralls @huan