Skip to content
Permalink
Browse files

irc: fix crash when receiving a malformed message 352 (who)

Thanks to Stuart Nevans Locke for reporting the issue.
  • Loading branch information
flashcode committed Feb 14, 2020
1 parent 694b5c9 commit c827d6fa864e2c0b79cea640c45272e83703081e
Showing with 2 additions and 1 deletion.
  1. +1 −0 ChangeLog.adoc
  2. +1 −1 src/plugins/irc/irc-protocol.c
@@ -20,6 +20,7 @@ https://weechat.org/files/releasenotes/ReleaseNotes-devel.html[release notes]

Bug fixes::

* irc: fix crash when receiving a malformed message 352 (who)
* irc: fix crash when a new message 005 is received with longer nick prefixes
* irc: fix crash when receiving a malformed message 324 (channel mode) (CVE-2020-8955)

@@ -4689,7 +4689,7 @@ IRC_PROTOCOL_CALLBACK(352)

if (argc > 8)
{
arg_start = (strcmp (argv[8], "*") == 0) ? 9 : 8;
arg_start = ((argc > 9) && (strcmp (argv[8], "*") == 0)) ? 9 : 8;
if (argv[arg_start][0] == ':')
{
pos_attr = NULL;

0 comments on commit c827d6f

Please sign in to comment.
You can’t perform that action at this time.