Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with regex in default triggers on *BSD #172

Closed
flashcode opened this Issue Aug 19, 2014 · 2 comments

Comments

Projects
None yet
2 participants
@flashcode
Copy link
Member

commented Aug 19, 2014

On FreeBSD and OpenBSD (at least), the default regex in triggers work only partially: \S is not supported and should then be replaced for example by [^\s].

@flashcode flashcode added the bug label Aug 19, 2014

@flashcode flashcode changed the title Problems with regex in default triggers on BSD Problems with regex in default triggers on *BSD Aug 19, 2014

@apoxa

This comment has been minimized.

Copy link

commented Aug 20, 2014

Replacing \S with [^\s] doesn't work if the name contains an 's'. For example
/secure set serverpass asdf
Doesn't hide 'asdf'.

@flashcode flashcode added this to the 1.1 milestone Aug 21, 2014

@flashcode flashcode self-assigned this Aug 21, 2014

@flashcode

This comment has been minimized.

Copy link
Member Author

commented Aug 21, 2014

@apoxa: yes, in fact, I'll replace \S by [^ ] which should be enough (there should be no tabs or whitespace like that in WeeChat command line).

@flashcode flashcode modified the milestones: 1.1, 1.0.1 Aug 22, 2014

@flashcode flashcode closed this in 333253e Aug 22, 2014

flashcode added a commit that referenced this issue Aug 22, 2014

trigger: fix regex used in default triggers to hide passwords (closes #…
…172)

"\S" is not supported on *BSD, so it is replaced by "[^ ]" (which should be
enough, since there should be no tabs or other whitespace different from
spaces in command line).

(cherry picked from commit 333253e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.