Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backlog missing when irc.look.buffer_open_before_autojoin is true #279

Closed
holomorph opened this Issue Dec 16, 2014 · 15 comments

Comments

Projects
None yet
2 participants
@holomorph
Copy link

holomorph commented Dec 16, 2014

i'm not seeing backlog in autojoined channels. I still see backlog in &bitlbee, but I guess that's different.

Toggling irc.look.buffer_open_before_autojoin to false restores backlogs in autojoin channels.

@flashcode

This comment has been minimized.

Copy link
Member

flashcode commented Dec 16, 2014

What are your logger.* settings?
I have no problem with default settings, maybe it's different if you use some buffer variables in path to log files.

@flashcode flashcode self-assigned this Dec 16, 2014

@flashcode flashcode added this to the 1.1 milestone Dec 16, 2014

@holomorph

This comment has been minimized.

Copy link
Author

holomorph commented Dec 16, 2014

From /set diff:

[file] (logger.conf)
  logger.file.mask = "$server/$channel.log"  (default: "$plugin.$name.weechatlog")
  logger.file.path = "~/.cache/weechat/logs"  (default: "%h/logs/")

[level] (logger.conf)
  logger.level.core.weechat = 0  (default: 9)
  logger.level.irc = 2  (default: 9)
@flashcode

This comment has been minimized.

Copy link
Member

flashcode commented Dec 18, 2014

I'm not able to reproduce the problem with your logger settings on a new config: the backlog is always displayed.
Can you try with a new config and no scripts loaded (possible with same logger settings)?

@flashcode

This comment has been minimized.

Copy link
Member

flashcode commented Dec 26, 2014

Some news about your problem?

@holomorph

This comment has been minimized.

Copy link
Author

holomorph commented Dec 26, 2014

I have to go hunting to see what's causing it :(

@flashcode

This comment has been minimized.

Copy link
Member

flashcode commented Jan 3, 2015

Some news about the problem?
The next release (1.1) is scheduled tomorrow, so if there's really a problem with this new option, it would be nice to fix before the release.

@holomorph

This comment has been minimized.

Copy link
Author

holomorph commented Jan 3, 2015

Hm, changing my logger settings from

[file] (logger.conf)
  logger.file.mask = "$server/$channel.log"  (default: "$plugin.$name.weechatlog")
  logger.file.path = "~/.cache/weechat/logs"  (default: "%h/logs/")

back to the defaults, I find the directory $server in logs, with the file $channel.log containing

2015-01-03 08:58:36     Option changed: logger.file.mask = "$server/$channel.log"  (default: "$plugin.$name.weechatlog")
2015-01-03 09:19:26     Option changed: logger.file.path = "%h/logs/"
@holomorph

This comment has been minimized.

Copy link
Author

holomorph commented Jan 3, 2015

Here's my current /set diff from a fresh config in weechat 6d12514

[server_default] (irc.conf)
  irc.server_default.nicks = "holomorph"  (default: "")
  irc.server_default.sasl_username = "holomorph"  (default: "")
  irc.server_default.ssl = on  (default: off)
  irc.server_default.ssl_cert = "~/.config/ssl/certs/holomorph.pem"  (default: "")
  irc.server_default.username = "holomorph"  (default: "")

[server] (irc.conf)
  irc.server.freenode.addresses = "chat.freenode.net/7000"  (default: (undefined))
  irc.server.freenode.autoconnect = on  (default: (undefined))
  irc.server.freenode.autojoin = "#weechat"  (default: (undefined))
  irc.server.freenode.sasl_password = "${sec.data.freenode}"  (default: (undefined))
  irc.server.freenode.ssl_dhkey_size = 1024  (default: (undefined))

Also copying the relevant sec.conf setting. I still get the issue. No backlog.

Beyond this, if I toggle irc.look.buffer_open_before_autojoin to off I get backlog again.

@flashcode

This comment has been minimized.

Copy link
Member

flashcode commented Jan 3, 2015

You should use $server and $channel only in the option logger.mask.irc because they are defined only on irc buffers (not core buffer for example).
See: https://weechat.org/files/doc/devel/weechat_user.en.html#logger_irc_files_by_server_channel

But for your logging problem, I still don't understand why you don't have the backlog with the new option...

@flashcode

This comment has been minimized.

Copy link
Member

flashcode commented Jan 3, 2015

Ah, I have an idea!
Can you check the case of channel name in your autojoin, vs the real channel joined? Are they different?
For example you have #WeeChat in autojoin, while the real channel name is #weechat (or reverse)?
Buffer names are case sensitive, so if WeeChat opens irc.freenode.#WeeChat instead of irc.freenode.#weechat, the backlog can not be read.

@flashcode

This comment has been minimized.

Copy link
Member

flashcode commented Jan 3, 2015

Hmm.. if logger.file.name_lower_case is on (default), this problem should not happen.

@holomorph

This comment has been minimized.

Copy link
Author

holomorph commented Jan 3, 2015

Ok, so far confirmed that only setting irc.server.freenode.autojoin = "#somechannel" (default: (undefined)) doesn't cause the issue. Time to bisect settings.

@flashcode

This comment has been minimized.

Copy link
Member

flashcode commented Jan 3, 2015

It looks like the problem happen when autoconnect is on, sometimes the irc plugin is loaded before logger plugin, and then the backlog can not be displayed when the buffers are opened on server connection.

@flashcode flashcode removed the waiting info label Jan 3, 2015

@flashcode flashcode closed this in 8f668bb Jan 6, 2015

@flashcode

This comment has been minimized.

Copy link
Member

flashcode commented Jan 6, 2015

Please tell me if the fix is OK for you.

@holomorph

This comment has been minimized.

Copy link
Author

holomorph commented Jan 7, 2015

Appears to be fixed. Thanks! \o/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.