Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User confirmation for /upgrade, /quit, ... #463

Closed
azrdev opened this Issue Jul 13, 2015 · 5 comments

Comments

Projects
None yet
4 participants
@azrdev
Copy link

azrdev commented Jul 13, 2015

I'd like to have a manual confirmation for "destructive" commands such as /upgrade or /quit, so as not to accidentally dis/re-connect all buffers.

@azrdev azrdev changed the title [feature] user confirmation for `/upgrade`, `/quit`, ... [feature] user confirmation for /upgrade, /quit, ... Jul 13, 2015

@flashcode

This comment has been minimized.

Copy link
Member

flashcode commented Jul 13, 2015

For /quit you can set this option: /set weechat.look.confirm_quit on.
The /upgrade should not "destroy" anything (except that you're disconnected and automatically reconnected to IRC servers, but only if you use SSL).

@flashcode flashcode changed the title [feature] user confirmation for /upgrade, /quit, ... User confirmation for /upgrade, /quit, ... Jul 13, 2015

@Mikaela

This comment has been minimized.

Copy link
Contributor

Mikaela commented Jul 13, 2015

if set, /quit command must be confirmed with extra argument "-yes" (see /help quit)

and when I accidentally scroll commands up with the up key and happen to hit enter when it says /quit -yes... What happens?

@flashcode

This comment has been minimized.

Copy link
Member

flashcode commented Jul 13, 2015

@Mikaela: this should never happen, if you recall a command which is /quit -yes, this would have quit WeeChat. The only case is if you type /quit -yes but don't execute it and save it in history. But if you recall that and press Enter, you know what you do.
For me it doesn't make sense to add extra confirmations on /quit (otherwise it would be very annoying).
I'll add similar behavior for /upgrade.

@Mikaela

This comment has been minimized.

Copy link
Contributor

Mikaela commented Jul 13, 2015

I think optimal behaviour would be having the same as what happens when you attempt pasting multiple lines by default "Are you sure that you wish to quit/upgrade/whatever [y/N]".

@Shawn-Smith

This comment has been minimized.

Copy link
Contributor

Shawn-Smith commented Jul 13, 2015

I think /upgrade should also have a -yes option, but other than that it's fine as it is.

and when I accidentally scroll commands up with the up key and happen to hit enter when it says /quit -yes... What happens?

That's just needless hand-holding.

@flashcode flashcode closed this in a02743b Jul 14, 2015

@flashcode flashcode added this to the 1.3 milestone Jul 14, 2015

@flashcode flashcode self-assigned this Jul 14, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.