Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/debug tags doesn't show tags of message if there's zero-width space character at the end of it #502

Closed
tomoe-mami opened this Issue Aug 22, 2015 · 4 comments

Comments

Projects
None yet
2 participants
@tomoe-mami
Copy link
Contributor

tomoe-mami commented Aug 22, 2015

If I send a message that has U+200B at the end of it and then run /debug tags, there won't be any tags displayed for it. Other people who run /debug tags won't be able to view the tags for that message too.

@flashcode

This comment has been minimized.

Copy link
Member

flashcode commented Aug 22, 2015

I think this is not specific to /debug tags but a bug caused by the zero width space, see the original bug report on savannah: https://savannah.nongnu.org/bugs/?40985

@flashcode flashcode added the bug label Aug 22, 2015

@flashcode

This comment has been minimized.

Copy link
Member

flashcode commented Aug 22, 2015

It can be reproduced with this command: /print -escape test \u200b message
The word "message" is not displayed.

@flashcode flashcode self-assigned this Aug 22, 2015

@flashcode flashcode added this to the 1.4 milestone Aug 22, 2015

@tomoe-mami

This comment has been minimized.

Copy link
Contributor Author

tomoe-mami commented Aug 22, 2015

Oh, sorry. Forgot to check savannah.

If I use /print -escape one\u200btwo, all of it is displayed. I select the text and dump the codepoint just to make sure all characters are there: https://i.imgur.com/mZkiDfy.png

So it's not displayed if there's space after \u200b ?

@flashcode

This comment has been minimized.

Copy link
Member

flashcode commented Aug 22, 2015

Yes, I found the problem in code. It happens only if a whole "word" (delimited by spaces) has a length of zero on screen, so for example a word with one or more U+200B chars will cause the display problem.
When WeeChat finds a word with length of zero (on screen), it considers the line has ended and displays a new line, which is wrong in this case.

flashcode added a commit that referenced this issue Aug 23, 2015

@flashcode flashcode closed this Aug 23, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.