Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xfer/DCC: Weechat crashes when sending empty file to yourself #53

Closed
jhenninger opened this Issue Apr 7, 2014 · 3 comments

Comments

Projects
None yet
3 participants
@jhenninger
Copy link

jhenninger commented Apr 7, 2014

This only happens when sending an empty file to yourself. When sending to another weechat instance, the transfer never even starts (at least in my tests).

Maybe sending of empty files should be disallowed completely?

Steps to reproduce:
/exec touch /tmp/foo
/dcc send <yournick> /tmp/foo

Then accept the incoming transfer.

@talisein

This comment has been minimized.

Copy link
Contributor

talisein commented Apr 8, 2014

Hmm, I just get a hang, rather than a crash. What platform are you on? And what version are you running?

@jhenninger

This comment has been minimized.

Copy link
Author

jhenninger commented Apr 8, 2014

I'm sorry, I also get a hang/freeze rather than a crash, dunno why I wrote crash in the OP. Does Weechat recover for you? I waited like 2 minutes and it still was frozen.
I'm on Debian Sid btw.

@talisein

This comment has been minimized.

Copy link
Contributor

talisein commented Apr 8, 2014

No it doesn't recover. It's trying to read a file descriptor but is blocking even though select() said there was data to read. It seems like xfer_network_write_pipe must have had a short write.

@flashcode flashcode added the bug label Apr 13, 2014

@flashcode flashcode closed this in db912de Apr 13, 2014

@flashcode flashcode added this to the 1.0 milestone Nov 16, 2014

@flashcode flashcode self-assigned this Nov 16, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.