Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server passwords doesn't start with colon with spaced password #602

Closed
kyrias opened this Issue Nov 23, 2015 · 4 comments

Comments

Projects
None yet
3 participants
@kyrias
Copy link

kyrias commented Nov 23, 2015

If the server password sent contains spaces the argument has to have a colon prepended to it so that the whole password is recognized as a single argument by the server. WeeChat currently just sends PASS <password>.

@kyrias

This comment has been minimized.

Copy link
Author

kyrias commented Nov 23, 2015

(For reference: znc/znc#1188)

@flashcode flashcode added the bug label Nov 23, 2015

@flashcode flashcode closed this in 9e9dd27 Nov 24, 2015

@flashcode flashcode added this to the 1.4 milestone Nov 24, 2015

@flashcode flashcode self-assigned this Nov 24, 2015

@Mikaela

This comment has been minimized.

Copy link
Contributor

Mikaela commented Nov 24, 2015

@flashcode I fear your fix breaks some IRCds when password without space is used. See hexchat/hexchat#1550 and the easiest fix would probably be irssi/irssi#362 (comment).

@flashcode

This comment has been minimized.

Copy link
Member

flashcode commented Nov 24, 2015

OK, I'll update accordingly.

@flashcode flashcode reopened this Nov 24, 2015

flashcode added a commit that referenced this issue Nov 24, 2015

irc: add a condition for colon before the password in PASS message (i…
…ssue #602)

Some weird IRC servers may refuse a PASS command with a colon, so we
send a colon only if the password contains spaces or begins with a
colon.

@flashcode flashcode closed this Nov 24, 2015

@flashcode

This comment has been minimized.

Copy link
Member

flashcode commented Nov 24, 2015

@Mikaela: it should be better with the second commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.