Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WeeChat doesn't support the /remove command. #91

Closed
Mikaela opened this Issue May 25, 2014 · 11 comments

Comments

Projects
None yet
3 participants
@Mikaela
Copy link
Contributor

Mikaela commented May 25, 2014

I used /remove and it went to the server instead of WeeChat understanding it.'

/remove #channel bot Bots go elsewhere, please.

Results to

XX:XX:XX <-- bot (bot!bot@bot) has left #channel (requested by Mikaela (Bots))

While it should have been

XX:XX:XX <-- bot (bot!bot@bot) has left #channel (requested by Mikaela (Bots go elsewhere, please.))

@flashcode flashcode added this to the 1.0 milestone May 25, 2014

@flashcode flashcode self-assigned this May 25, 2014

@Shawn-Smith

This comment has been minimized.

Copy link
Contributor

Shawn-Smith commented May 25, 2014

I can't reproduce this, works fine for me.

16:21:35 network +| remove Shawn #Testing2 Testing stuff
16:21:35 network +| :server NOTICE #Testing2 :Shawn removed Shawn from the channel
16:21:35 network +| :server NOTICE Shawn :*** Shawn removed you from #Testing2 with the message: Testing stuff
16:21:35 network +| :Shawn!Shawn@host PART #Testing2 :Removed by Shawn: Testing stuff

Edit :: Also, you sent the command wrong. It's REMOVE <nick> <#channel> <reason> not REMOVE <#channel> <nick> <reason>
Edit 2 :: Nevermind, that's an inspircd-specific bug, you had it right.

@Mikaela

This comment has been minimized.

Copy link
Contributor Author

Mikaela commented May 25, 2014

Oh, so I used invalid syntax which was sent to server and that is why it did what it did?

@Shawn-Smith

This comment has been minimized.

Copy link
Contributor

Shawn-Smith commented May 25, 2014

@Mkaysi I'm not sure what caused your error, but I can use it just fine.

@Mikaela

This comment has been minimized.

Copy link
Contributor Author

Mikaela commented May 25, 2014

@Shawn-Smith which version are you on?

23:31:02 WeeChat 1.0-dev (git: v0.4.3-542-g8e1d5e5) [compiled on May 21 2014 09:26:25]

@Shawn-Smith

This comment has been minimized.

Copy link
Contributor

Shawn-Smith commented May 25, 2014

WeeChat 0.4.3 [compiled on May 20 2014 22:42:06]

It's the version currently in the x86_64 cygwin repo.

@Mikaela

This comment has been minimized.

Copy link
Contributor Author

Mikaela commented May 25, 2014

Your syntax seems to be doing nothing for me. I wonder if something was changed recently.

@Shawn-Smith

This comment has been minimized.

Copy link
Contributor

Shawn-Smith commented May 25, 2014

You have the irc.network.send_unknown_commands setting on, right?

@Mikaela

This comment has been minimized.

Copy link
Contributor Author

Mikaela commented May 26, 2014

Yes, but if the command was known, it wouldn't be sent to server for processing, would it?

@Shawn-Smith

This comment has been minimized.

Copy link
Contributor

Shawn-Smith commented May 26, 2014

The command isn't known, that's why you need that setting on. Adding this command in WeeChat isn't going to change the way it's sent to the server at all.

@flashcode

This comment has been minimized.

Copy link
Member

flashcode commented May 26, 2014

I'm currently adding the command in WeeChat, and it will change a small thing: WeeChat will add a colon before arguments (so that they are not cut). By the way you can already do that: /remove #chan nick :the reason here or /quote remove #chan nick :the reason here).
In the WeeChat command, for ease of use, I'll allow same syntax as /kick command, ie the channel can be omitted (defaults to current channel), for example: /remove nick the reason here.

@Mikaela

This comment has been minimized.

Copy link
Contributor Author

Mikaela commented May 26, 2014

The command isn't known, that's why you need that setting on. Adding this command in WeeChat isn't going to change the way it's sent to the server at all.

I have that enabled, that is what I meant with "Yes,".

But this seems to be fixed, so I will /upgrade soon :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.