Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: add option weechat.look.buffer_time_same #1127

Closed
wants to merge 3 commits into from

Conversation

sim642
Copy link
Member

@sim642 sim642 commented Jan 3, 2018

Just like weechat.look.prefix_same_nick allows not repeating the nick if it's the same for consecutive lines, this PR adds an option to not repeat the displayed time if it's the same for consecutive lines. The option behaves similarly: empty string means disabled, non-empty string is evaluated (to allow colors) to use a custom string (may be a space for just hiding).

Custom strings are left-aligned and padded to the length of the displayed time. Too long custom strings are simply truncated. While it would theoretically be possible to add line prefix like alignment customization options, it is an unnecessary complication for this change, especially since it hasn't been needed so far as the time has had constant aligned width.

Feature requested by pdx in #weechat.

@flashcode flashcode added the feature New feature request label Jan 3, 2018
@kholland950
Copy link

+1, would greatly appreciate this feature

@flashcode flashcode closed this in 97e9046 Apr 13, 2019
@flashcode flashcode added this to the 2.5 milestone Apr 13, 2019
@flashcode flashcode self-assigned this Apr 13, 2019
@novasenco
Copy link

so, how do get the timestamp of the message into buffer_time_same? Obviously, ${date:%H:%M} doesn't work...

@flashcode
Copy link
Member

@novasenco: this is not possible, this option just allows you to display an alternate string, which does not contain the date of the message.

Feel free to add a feature request if you need to include the date of the message in this option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants