Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strip colon, if present, from ACCOUNT value #1525

Closed
wants to merge 1 commit into from
Closed

strip colon, if present, from ACCOUNT value #1525

wants to merge 1 commit into from

Conversation

@jesopo
Copy link
Contributor

@jesopo jesopo commented Jun 15, 2020

I noticed this after updating to a 2.9-dev build that prints ACCOUNT lines:

-- user has identified as :user

this pull request is a band-aid. the real solution here is to correctly tokenise IRC data as soon as it's read so :trailing parameters are just treated as another param in the argv array.

@codecov-commenter
Copy link

@codecov-commenter codecov-commenter commented Jun 15, 2020

Codecov Report

Merging #1525 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1525   +/-   ##
=======================================
  Coverage   35.04%   35.04%           
=======================================
  Files         204      204           
  Lines       84374    84375    +1     
=======================================
+ Hits        29571    29572    +1     
  Misses      54803    54803           
Impacted Files Coverage Δ
src/plugins/irc/irc-protocol.c 87.59% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 340d664...dbb3c74. Read the comment docs.

Loading

@flashcode
Copy link
Member

@flashcode flashcode commented Jun 15, 2020

Hi,
Thanks for the PR, I fixed with a slightly different solution.

Loading

@flashcode flashcode closed this Jun 15, 2020
@flashcode flashcode self-assigned this Jun 15, 2020
@flashcode flashcode added the bug label Jun 15, 2020
@flashcode flashcode added this to the 2.9 milestone Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants