Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xfer: bind to wildcard address when sending #173

Merged
merged 1 commit into from Nov 9, 2014

Conversation

Projects
None yet
2 participants
@talisein
Copy link
Contributor

talisein commented Aug 20, 2014

When #5 was fixed, we started to always bind to the local address
connected to the irc server because the xfer.network.own_ip address
may not be able to be bound to when NATed. But this means when the
own_ip address is a different family (IPv4 vs IPv6) from the irc
server connection, we were listening for connections on the wrong
interface.

This patch lets us figure out which family is being used,
(xfer.network.own_ip's family, or the irc connection's family
otherwise) and bind() into the correct family via that family's
wildcard address.

xfer: bind to wildcard address when sending
When #5 was fixed, we started to always bind to the local address
connected to the irc server because the xfer.network.own_ip address
may not be able to be bound to when NATed. But this means when the
own_ip address is a different family (IPv4 vs IPv6) from the irc
server connection, we were listening for connections on the wrong
interface.

This patch lets us figure out which family is being used,
(xfer.network.own_ip's family, or the irc connection's family
otherwise) and bind() into the correct family via that family's
wildcard address.

@talisein talisein force-pushed the talisein:xfer_wildcard branch from 2a779e1 to 5284646 Aug 20, 2014

@flashcode flashcode added the bug label Aug 29, 2014

@flashcode flashcode added this to the 1.1 milestone Nov 1, 2014

@flashcode flashcode merged commit 5284646 into weechat:master Nov 9, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@flashcode flashcode self-assigned this Nov 9, 2014

@talisein talisein deleted the talisein:xfer_wildcard branch Oct 4, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.