Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

irc: add support for CAP extended-join #212

Merged
merged 1 commit into from Nov 1, 2014

Conversation

Projects
None yet
2 participants
@maxteufel
Copy link
Contributor

commented Sep 22, 2014

Basic support for CAP extended-join (https://github.com/ircv3/ircv3-specifications/blob/master/extensions/extended-join-3.1, #143) . I think the code could be shorter. Code is shorter now, should be ready to merge.

@maxteufel maxteufel force-pushed the maxteufel:feature/extended-join branch 2 times, most recently from 86139a0 to e4916f9 Sep 23, 2014

@maxteufel maxteufel force-pushed the maxteufel:feature/extended-join branch from e4916f9 to aa2934c Nov 1, 2014

@maxteufel

This comment has been minimized.

Copy link
Contributor Author

commented Nov 1, 2014

12:33:28 <Mikaela> but it talks something about merge commits even if it says to be ready to merged. I wonder why it wasn't ever merged.

Just resolved the merge conflicts. Also do note that this PR does not add the following things:

  • store the account name/gecos of an user when they join (needed for account-notify)
  • strip colors/special characters from realnames
  • Edit: it also doesn't add extended-join to the list of supported CAPs in the configuration help ;)

@flashcode flashcode merged commit aa2934c into weechat:master Nov 1, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@flashcode flashcode added this to the 1.1 milestone Nov 1, 2014

@flashcode flashcode self-assigned this Nov 1, 2014

@maxteufel maxteufel deleted the maxteufel:feature/extended-join branch Nov 1, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.