Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

irc: add support for CAP cap-notify #477

Merged
merged 1 commit into from Oct 18, 2015

Conversation

Projects
None yet
4 participants
@maxteufel
Copy link
Contributor

commented Aug 8, 2015

No description provided.

@Mikaela

This comment has been minimized.

Copy link
Contributor

commented Oct 1, 2015

Is there something wrong with PR or when can we expect this to come to WeeChat?

If I have cap-notify enabled and away-notify in irc.server.blah.capabilities and blah starts offering away-notify, will it be automatically enabled? There was some script which required everything to be configured manually and I don't think it was helpful at all.

http://wiki.znc.in/WeeChat is also awaiting the capability and the safe capabilities.

@maxteufel

This comment has been minimized.

Copy link
Contributor Author

commented Oct 1, 2015

Is there something wrong with PR or when can we expect this to come to WeeChat?

I don't plan to change anything in this PR, I tested it and it works.

If I have cap-notify enabled and away-notify in irc.server.blah.capabilities and blah starts offering away-notify, will it be automatically enabled?

Yes, all capabilities enabled in the config should be requested when the server starts offering it (note this doesn't support SASL reauth).


/* Assume that we're not requesting any already-enabled capabilities
* TODO SASL Reauthentication */
ptr_cap_option = IRC_SERVER_OPTION_STRING(server,

This comment has been minimized.

Copy link
@talisein

talisein Oct 4, 2015

Contributor

This is all nearly copy-paste from 366-408. Why not make a cap parsing function?

@Mikaela

This comment has been minimized.

Copy link
Contributor

commented Oct 18, 2015

At IRC it was said that it helps if we merge these manually and test. On the latest WeeChat from just now, this appears to work:

2015-10-18 10:37:18+0300 -- irc: client capability, currently enabled: account-notify cap-notify extended-join multi-prefix server-time userhost-in-names
2015-10-18 10:37:18+0300 -- irc: client capability, currently enabled: account-notify away-notify cap-notify extended-join multi-prefix server-time userhost-in-names
2015-10-18 10:37:18+0300 -- irc: client capability, currently enabled: cap-notify multi-prefix server-time userhost-in-names
2015-10-18 10:37:18+0300 -- irc: client capability, currently enabled: cap-notify multi-prefix server-time userhost-in-names
2015-10-18 10:37:18+0300 -- irc: client capability, currently enabled: cap-notify multi-prefix server-time userhost-in-names
2015-10-18 10:37:18+0300 -- irc: client capability, currently enabled: cap-notify multi-prefix server-time userhost-in-names
2015-10-18 10:37:18+0300 -- irc: client capability, currently enabled: account-notify away-notify cap-notify extended-join multi-prefix server-time userhost-in-names
2015-10-18 10:37:18+0300 -- irc: client capability, currently enabled: multi-prefix userhost-in-names

As I use ZNC, at least away-notify and account-notify wouldn't appear otherwise.

@flashcode flashcode merged commit 00d2c9e into weechat:master Oct 18, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@flashcode flashcode added this to the 1.4 milestone Oct 18, 2015

@flashcode flashcode self-assigned this Oct 18, 2015

@maxteufel maxteufel deleted the maxteufel:feature/cap-notify branch Oct 19, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.