Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set up the controls lists to just be lists #130

Closed
juniperlsimonis opened this issue Jul 5, 2019 · 0 comments
Closed

set up the controls lists to just be lists #130

juniperlsimonis opened this issue Jul 5, 2019 · 0 comments
Milestone

Comments

@juniperlsimonis
Copy link
Contributor

@juniperlsimonis juniperlsimonis commented Jul 5, 2019

improve the API by making the control arguments to be looking just for a list (not a special kind of list) and take default setting for if the specific element of the list is missing

@juniperlsimonis juniperlsimonis added this to the v0.2.0 milestone Jul 5, 2019
juniperlsimonis added a commit that referenced this issue Jul 8, 2019
The control lists have been made easier to interact with. Primarily, the arguments that previously required `LDA_controls_list`, `TS_controls_list`, or `LDA_TS_controls_list` inputs now take general `list` inputs (so  `LDA_TS` does not need to have a nested set of control functions). Each control list is passed through a function (`LDA_set_control`, `TS_control`, or `LDA_TS_control`) to set any non-input values to their defaults. This also allows the removal of those controls list class definitions. ([addresses issue 130](#130))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.