WIP: Remove unused code form lib/tools.py #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanwhite
changed the title
|
The remote tests are currently showing meaningful failures. This PR should not be merged at the moment. |
final_cleanup in tools simply passed. The function was called in lib/download, but no value was stored, so this wasn't influencing the execution of the code.
|
Tests are passing now, but testing output shows repeated instances of:
which shouldn't be happening. |
ethanwhite
force-pushed
the
dead-code
branch
2 times, most recently
from
33cccbc
to
990c23c
Compare
|
I had missed an import of
is resulting from actually testing the old script rather than the new one due to a script order issue. @henrykironde if you agree I think we can merge this, but I'm also happy to wait until we work out that ordering of script priority issue before merging to make sure that extra output goes away. |
henrykironde
added a commit
that referenced
this pull request
Feb 9, 2016
WIP: Remove unused code form lib/tools.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly testing code from 2010 that we don't use any more.