Improvement: transition duration/delay number parsing #10

Closed
yyx990803 opened this Issue Jan 10, 2017 · 2 comments

Projects

None yet

2 participants

@yyx990803

Currently, transition duration/delay such as 0.5s is preserved as-is. When passed to Weex's animation API which expects number of milliseconds, this seems to be treated as 0.5ms instead (likely via parseInt).

We can of course check this in the runtime framework, but ideally weex-styler could normalize these durations during the build phase.

@songsiqi
Contributor

@yyx990803 OK. The unit s could be formatted to ms. Is it necessary to delete ms unit?

@yyx990803

Normalizing durations into integers would be nice.

@songsiqi songsiqi closed this in 407218e Jan 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment