Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Isn't auto merging #317

Closed
Milo123459 opened this issue Mar 30, 2021 · 14 comments
Closed

Isn't auto merging #317

Milo123459 opened this issue Mar 30, 2021 · 14 comments
Assignees
@wei
Labels
bug Something isn't working

Comments

@Milo123459
Copy link

I forked vscode and pull made the PR but it isn't merging the PR into the main branch, does it do this automatically or manually?
@wei
Copy link
Owner

wei commented Mar 30, 2021

Thanks for the report, please don't merge it manually and I will take a look~ Milo123459/vscode#1

@wei wei added the bug Something isn't working label Mar 30, 2021
@wei wei self-assigned this Mar 30, 2021
@Milo123459
Copy link
Author

Alright!

@wei
Copy link
Owner

wei commented Mar 30, 2021

Did you uninstall and reinstall the app? It worked when I executed manually. I suspect the token was outdated so it didn't have permission~

@wei wei closed this as completed Mar 30, 2021
@wei
Copy link
Owner

wei commented Mar 30, 2021

Please reopen the issue if you continue to see this problem~

@Milo123459
Copy link
Author

Wait @wei question, when does it decide to automerge? After no commits for x amount of time?

@Milo123459
Copy link
Author

@wei For some reason I can't reopen this issue.. https://github.com/Milo123459/vscode another PR is open and no sign of being merged

@wei
Copy link
Owner

wei commented Mar 31, 2021 •
edited

It should merge but we have too many repos processing at the same time. I'll increase timeout and see if it picks you up.

@wei wei reopened this Mar 31, 2021
@Milo123459
Copy link
Author

Ah, I suggest maybe automatically merging after no commit to repo after X minutes? And from my understanding the pull bot is always merging a PR somewhere else and the PR created is somewhere in the backlog of it, is that true?

@wei
Copy link
Owner

wei commented Mar 31, 2021

Ok it worked for now. I'll close it but please feel free to continue the conversation in this thread.

Pull will merge pull requests as long as the the pull requests can be merged and the repo is not configured to not merge .
Could you rephrase your second question?

@wei wei closed this as completed Mar 31, 2021
@Milo123459
Copy link
Author

Okay. Then why didn't pull just merge the PR at the start of it being created?

@wei
Copy link
Owner

wei commented Mar 31, 2021 •
edited

Two reasons, GitHub takes some time to calculate whether the pull request can be merged. This information/action is not available right away. Secondly, Pull is handling too many repositories concurrently and requests sometimes time out due to socket errors and other network issues. I've increased the job timeout so hopefully it will happen less often~

@Milo123459
Copy link
Author

Ah, sounds good! Thanks.

@wei
Copy link
Owner

wei commented Apr 1, 2021 •
edited

I just saw another PR come in on your repo. But unfortunately the server resources are constrained.

Hopefully I can get some users to sponsor a portion of the cost so I can scale up the server~

@Milo123459
Copy link
Author

OK, thanks for clearing it up. BTW, this project is amazing, so useful!

@cangSDARM cangSDARM mentioned this issue Apr 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wei wei

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wei @Milo123459