Permalink
Browse files

update OT version; remove brave UnitTest since brave-opentracing comp…

…iled with jdk8
  • Loading branch information...
1 parent a179cc0 commit 4d84acf5255b4300245cf1e308c31694df923133 @rayzhang0603 rayzhang0603 committed Dec 21, 2016
@@ -21,7 +21,7 @@
<url>https://github.com/weibocom/motan</url>
<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
- <opentracing.version>0.20.2</opentracing.version>
+ <opentracing.version>0.20.4</opentracing.version>
</properties>
<dependencies>
<dependency>
@@ -16,7 +16,7 @@
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertTrue;
import io.opentracing.Tracer;
-import io.opentracing.impl.BraveTracer;
+//import io.opentracing.impl.BraveTracer;
import io.opentracing.mock.MockSpan;
import io.opentracing.mock.MockTracer;
@@ -110,10 +110,11 @@ public void testRefererFilter() {
assertEquals(response, res);
checkMockTracer();
- tracer = new BraveTracer();// use bravetracer
- res = OTFilter.filter(refer, request);
- assertEquals(response, res);
- checkBraveTrace();
+ // brave test must run with jdk1.8
+// tracer = new BraveTracer();// use bravetracer
+// res = OTFilter.filter(refer, request);
+// assertEquals(response, res);
+// checkBraveTrace();
}
@Test
@@ -148,12 +149,12 @@ private void checkMockTracer() {
}
}
- private void checkBraveTrace() {
- if (tracer instanceof BraveTracer) {
- assertTrue(request.getAttachments().containsKey("X-B3-TraceId"));
- assertTrue(request.getAttachments().containsKey("X-B3-SpanId"));
- assertTrue(request.getAttachments().containsKey("X-B3-Sampled"));
- }
- }
+// private void checkBraveTrace() {
+// if (tracer instanceof BraveTracer) {
+// assertTrue(request.getAttachments().containsKey("X-B3-TraceId"));
+// assertTrue(request.getAttachments().containsKey("X-B3-SpanId"));
+// assertTrue(request.getAttachments().containsKey("X-B3-Sampled"));
+// }
+// }
}

0 comments on commit 4d84acf

Please sign in to comment.