Skip to content

Conversation

@nbertagnolli
Copy link

Sorry, I noticed in the last PR now the action fails on master because an init was missing a docstring. I added one to get the action passing on master! Thanks for the great repository!

@sourcery-ai
Copy link

sourcery-ai bot commented Aug 11, 2022

Sourcery Code Quality Report

This PR has an average code quality of %

Quality metrics Before After Change
Complexity
Method Length 2.00 ⭐
Working memory
Quality % % %
Other metrics Before After Change
Lines 1
Changed files Quality Before Quality After Quality Change
tests/init.py % % %

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@weibullguy
Copy link
Owner

Lol. Yeah, I missed that too until after I merged your other PR and the lint failed. But, hey, a real world example of your fix in action! I'm glad you're finding it useful.

@weibullguy weibullguy merged commit af9b421 into weibullguy:master Aug 11, 2022
@nbertagnolli
Copy link
Author

Haha nice to see the change working 😅 : ). I don't think issues are enabled for this repository, but I was wondering if you'd be interested in me doing a refactor of the bash script so that all of the style checks run in the action and then it exits at the end if any one of them fail. I think as it is now the action exits as soon as one lint fails, but I find for code reviews it can be nice to see a report of everything that went wrong. However, this comes with the downside of more action compute. So I could see an argument for either way. Anyway, I'd love to tackle that if you're open to a PR :D.

@weibullguy weibullguy added the bug Something isn't working label Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants