Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Skip'ing on a Source does not work #248
The following was reported by user ahux on Stack Overflow at Skip'ing on a Source does not work:
Below is the runnable test case using strings.
Here the [un]expected output:
Looking at the documentation for BufferedTransformation::Skip:
Part of me wants to say, its working as expected because the operation is on the "output buffer" modulo
However, the other part of me says its not working as expected, regardless of the language lawyering.
As I step the code, I see exactly what's happening (the "working as expected" from above):
I'm wondering if we should special case the
The pain point seems to be
Maybe the way to approach this is to temporarily attach a discard filter, and
We have to be careful we don't break existing code in the field. This is worrisome because code in the field is a wild card we don't control.
The digested version of the analysis and open questions are:
I think the way to go here is to provide a member function on
The problem is, its so fundamental that it effects nearly every filter related class. Its a effectively a breaking change.
I'm going to stall on this issue at the moment.