Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Couldn't connect to Hacker News" Error when loading Top #243

Closed
Ferlow opened this issue Sep 21, 2022 · 1 comment · Fixed by #244
Closed

"Couldn't connect to Hacker News" Error when loading Top #243

Ferlow opened this issue Sep 21, 2022 · 1 comment · Fixed by #244

Comments

@Ferlow
Copy link

Ferlow commented Sep 21, 2022

Version: 4.7.4

Description

The Top category doesnot load and shows "Couldn't connect to Hacker News". Other categories load fine.

photo_2022-09-21_14-38-55

Steps to Reproduce

  1. Load Hackers App
  2. Wait a few seconds
  3. Error shows and page remains blank

Expected behavior: Top posts load.

Actual behavior: Top posts didn't load.
@weiran
Copy link
Owner

weiran commented Sep 21, 2022 •
edited
Loading

This is because the link submitted for the BetterBird post is https://www.betterbird.eu/## with a double hash at the end. For some reason Swift URL parsing rejects this even though it's a valid URL, when then breaks down the whole parsing chain.

@weiran weiran mentioned this issue Sep 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes Betterbird URL bug weiran/Hackers
2 participants
@weiran @Ferlow