Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

work with org-attach #66

Closed
shelper opened this issue Apr 14, 2019 · 7 comments
Labels

Comments

@shelper
Copy link

@shelper shelper commented Apr 14, 2019

now if i run org-noter on a headline, it ask for the path for the pdf file
but org mode actually come with org-attach, which would be useful if org-noter automatically find the attached file and i dont have to type any more
is this an easy feature to add?

@weirdNox

This comment has been minimized.

Copy link
Owner

@weirdNox weirdNox commented Apr 21, 2019

This has been on my backlog for quite some time, thanks for reminding me!

I don't think it would take too much time to do that, but I am a bit short on time currently, so it will take some time until it is implemented :/

@rosetree

This comment has been minimized.

Copy link

@rosetree rosetree commented Aug 27, 2019

This would probably also enhance the combination with org-brain, which supports attachments from the visualized setting.

What would you do about multiple attachments? Should the first selection add a document property or should the attachment always be selected again? Both seem to be useful. The second approach is not as fast for future noter sessions, but allows to share notes between different versions of a document.

@weirdNox

This comment has been minimized.

Copy link
Owner

@weirdNox weirdNox commented Aug 28, 2019

I was thinking of asking which file we wanted to use as document, on the first run, and saving that as NOTER_DOCUMENT; then it would work as it works now.

I wasn't planning on supporting multiple documents because, even with versions of the same document, it could change significantly, having the same content on different pages, which would make org-noter useless (at least with my type of annotations, see fuxialexander/org-pdftools).

However, I could also implement a function that lists once again the different attachments, and changes NOTER_DOCUMENT accordingly before calling org-noter, which you could use to override the version you're seeing.

@weirdNox weirdNox closed this in b8d8184 Aug 28, 2019
@weirdNox

This comment has been minimized.

Copy link
Owner

@weirdNox weirdNox commented Aug 28, 2019

I believe this is done! Please test it and report back :)

Also, if you want to choose another attached file, use 2 universal prefix arguments when executing org-noter, which overrides the annotated document. You could write a wrapper for that, if you use it a lot.

@rosetree

This comment has been minimized.

Copy link

@rosetree rosetree commented Sep 12, 2019

Thanks, @weirdNox! It works great in combination with org-brain. This is a fantastic feature :)

@yiufung

This comment has been minimized.

Copy link

@yiufung yiufung commented Nov 6, 2019

Just to say this is really really useful feature and thanks for working on it! Discovering org-attach and org-noter individually have given me so much help, and combining them is just magnificence at another level. This could've been in README for more attention. Thanks again for the great work!

@weirdNox

This comment has been minimized.

Copy link
Owner

@weirdNox weirdNox commented Nov 11, 2019

I always forget to add new features to the README! :D
Thanks for the kind words and for the reminder :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.