New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swimlane feature messes with display of detailed view #1444

Closed
Badpat opened this Issue Jan 29, 2018 · 31 comments

Comments

Projects
None yet
9 participants
@Badpat
Copy link

Badpat commented Jan 29, 2018

Issue

Impacted version: 0.67.0

Server Setup Information:

Problem description:

  • be as explicit has you can
  • describe the problem and its symptoms
  • explain how to reproduce
  • attach whatever information that can help understanding the context (screen capture, log files)

Today I upgraded to the latest wekan version. After upgrade I now have the swimlane feature but this leads to some problems:

  1. If I deactivate the swimlane view, cards are not being opened correctly. The mini-card moves slightly to the right, as usual, but there is no detailed view being displayed.

  2. If swimlane view is used, the detailed view of the opened card is being shown multiple times. Once in each lane.

Tested with Chrome (Version 64.0.3282.119) and Firefox (Version 58.0).

@johnleeming

This comment has been minimized.

Copy link

johnleeming commented Jan 29, 2018

Swimlanes also seem to mess with drag & drop ordering of cards in a list - if I move a card in swimlanes display it juts goes back to where it was. In the list view dragging on a card moves it out of the window and puts a whole bunch of placeholders in eth list but won't allow teh card back in.

Wekan 0,67 on Heroku, browser is Vivaldi | 1.11.917.43

@fbatschi

This comment has been minimized.

Copy link

fbatschi commented Jan 29, 2018

Further details for case 1:
The JS Console shows an error "There is no route for the path /b/boardid/boardname/cardname whith boardname and cardname being the corresponding values from the board.

@fbatschi

This comment has been minimized.

Copy link

fbatschi commented Jan 30, 2018

is there a problem to downgrade? Did anyone try this?
Or does this mess with the database structure?

The current version is actually unusable with the swimlane feature.

@xet7

This comment has been minimized.

Copy link
Member

xet7 commented Jan 30, 2018

@fbatschi

I do recommend backups anyway before upgrade and downgrade, just in case.
https://github.com/wekan/wekan/wiki/Export-Docker-Mongo-Data

Example of downgrade:
#1438 (comment)

@andresmanelli

Can you look at above comments for future swimlanes improvements?

@DissCent

This comment has been minimized.

Copy link

DissCent commented Jan 30, 2018

I experience the same problems - but for some reason, I also can't switch from swimlanes mode to the classic one - if I try, the Javascript console reports something like "Access denied" and the UI returns back to the swimlanes view. I am logged in though, checked this twice. Also a re-login doesn't solve this problem.

@xet7

This comment has been minimized.

Copy link
Member

xet7 commented Jan 30, 2018

@DissCent

Do you mean bugs that recent Chrome version did bring when they broke stuff?
#656

For me Wekan works fine in Firefox. Chrome is just slow, memory-hungry and buggy, I only use it when something does not work in Firefox.

@DissCent

This comment has been minimized.

Copy link

DissCent commented Jan 30, 2018

@xet7 I use Firefox as my main browser :) but I also can't move cards in the Swimlane view and have the issue that I can't exit the swimlane view.

@xet7

This comment has been minimized.

Copy link
Member

xet7 commented Jan 30, 2018

@DissCent

I presume you have old version of Wekan. I can move cards and switch lists/swimlane view just fine in newest version. Please reinstall using some of these images:

image: quay.io/wekan/wekan
or
image: wekanteam/wekan

Here is info of how to upgrade:
#1438 (comment)

@DissCent

This comment has been minimized.

Copy link

DissCent commented Jan 30, 2018

@xet7 Thank you! I was on the latest version already (wekanteam/wekan:latest) and even after reinstalling, moving cards did not work (or switching from swimlanes to lists).

However, as you suggested, switching back to v0.63 resolved my issues. I guess I'll wait for a bugfix release then.

@xet7

This comment has been minimized.

Copy link
Member

xet7 commented Jan 30, 2018

@DissCent

What version of Firefox you have? I have Firefox v58 for Ubuntu 17.10 64bit.

What operating system you use? Linux/Windows/Mac/something else ?

@DissCent

This comment has been minimized.

Copy link

DissCent commented Jan 30, 2018

@xet7 I also use Firefox 58.0 on Manjaro Linux (which is basically the same as Arch Linux) x64.

@xet7

This comment has been minimized.

Copy link
Member

xet7 commented Jan 30, 2018

@DissCent

Can you try this image?

image: quay.io/wekan/wekan

I don't really know where you are getting that bug. I do see that there is build failures at Docker Hub. Quay usually works better.

@DissCent

This comment has been minimized.

Copy link

DissCent commented Jan 30, 2018

@xet7 I already tried that one a couple of minutes ago - but still no luck :(

@xet7

This comment has been minimized.

Copy link
Member

xet7 commented Jan 30, 2018

@DissCent

In Admin Panel/Version does it show that Wekan version is v0.68 ? If not, you have not removed old containers and images, and you are running old version.

@xet7

This comment has been minimized.

Copy link
Member

xet7 commented Jan 30, 2018

It seems that Docker Hub has old version.

@DissCent

This comment has been minimized.

Copy link

DissCent commented Jan 30, 2018

@xet7

So I stopped wekan-app, did "docker rm wekan-app" and removed all wekan-app images with "docker rmi <...>". I rolled back my database to v0.63 format, set the image to "quay.io/wekan/wekan" and used "docker-compose up -d". The version inside Wekan now shows "0.68.0". However, the issues still remain (also tested with other browsers).

As an example, if I press the button "Swimlanes" to switch the view, the following gets sent to the server:

{"msg":"method","method":"/boards/update","params":[{"_id":"NxTfQAHsCa6CDGKuC"},{"$set":{"view":"board-view-lists","modifiedAt":{"$date":1517315412066}}},{}],"id":"13"}

And this is the response:

a["{\"msg\":\"result\",\"id\":\"13\",\"error\":{\"isClientSafe\":true,\"error\":403,\"reason\":\"Access denied\",\"message\":\"Access denied [403]\",\"errorType\":\"Meteor.Error\"}}"]

@scoubidoo

This comment has been minimized.

Copy link

scoubidoo commented Jan 30, 2018

ok for me in v0.68 whit Quay.io image

@xet7

This comment has been minimized.

Copy link
Member

xet7 commented Jan 30, 2018

@DissCent

I think your MongoDB install is broken.

You need to backup your MongoDB database with mongodump, reinstall MongoDB like for example remove MongoDB container and image, and restore:
https://github.com/wekan/wekan/wiki/Export-Docker-Mongo-Data

You can use MongoDB version that's in Docker Compose file:
https://github.com/wekan/wekan-mongodb

@johnleeming

This comment has been minimized.

Copy link

johnleeming commented Jan 30, 2018

I have updated to 0.68 - pull request to my Github clone then Heroku autobuilds from that. I am still getting the errors
image.

I try to move "job 5" in this test board in list view and get
image
in swim lane view I can move cards between lanes but if I try to change order of cards within one swim lane it just goes back to where it was before

@DissCent

This comment has been minimized.

Copy link

DissCent commented Jan 30, 2018

@xet7

I cleaned my MongoDB container and with a clean install, switching between swimlanes and lists now works correctly.
However, the same issues as @johnleeming still remain for me.

@andresmanelli

This comment has been minimized.

Copy link
Contributor

andresmanelli commented Jan 30, 2018

@DissCent @johnleeming I'll try to take a look this week, I have the same behavior.

@andresmanelli

This comment has been minimized.

Copy link
Contributor

andresmanelli commented Jan 31, 2018

Hello everyone, I updated my fork. The two last commits solve the drag and detail view bugs for me.

@xe7 could you take a look?

EDIT: Not tested the detailed view in lists-only mode. I'm updating meteor right now

@andresmanelli

This comment has been minimized.

Copy link
Contributor

andresmanelli commented Jan 31, 2018

Update:

Now details view is displayed in lists-only mode. Could someone give it a try?

@gramakri

This comment has been minimized.

Copy link

gramakri commented Jan 31, 2018

@andresmanelli I tried your branch quickly but getting some errors (I am using ff9ca75 from your fork). This is a fresh installation and clicking 'Add' does not work.

There is no route for the path: / f361e2be3bd4e39c74d7f68b56d033ddce131baf.js:247:5870
	router.js/f.prototype._notfoundRoute https://test.smartserver.space/f361e2be3bd4e39c74d7f68b56d033ddce131baf.js:247:5870
	router.js/f.prototype._updateCallbacks/< https://test.smartserver.space/f361e2be3bd4e39c74d7f68b56d033ddce131baf.js:247:7528
	index.js/s.prototype.middleware/< https://test.smartserver.space/f361e2be3bd4e39c74d7f68b56d033ddce131baf.js:247:15549
	r https://test.smartserver.space/f361e2be3bd4e39c74d7f68b56d033ddce131baf.js:247:14952
	index.js/n.dispatch https://test.smartserver.space/f361e2be3bd4e39c74d7f68b56d033ddce131baf.js:247:15004
	index.js/n.replace https://test.smartserver.space/f361e2be3bd4e39c74d7f68b56d033ddce131baf.js:247:14783
	router.js/f.prototype.initialize/</e._page[t] https://test.smartserver.space/f361e2be3bd4e39c74d7f68b56d033ddce131baf.js:247:6212
	index.js/n.start https://test.smartserver.space/f361e2be3bd4e39c74d7f68b56d033ddce131baf.js:247:14080
	n https://test.smartserver.space/f361e2be3bd4e39c74d7f68b56d033ddce131baf.js:247:11779
	router.js/f.prototype.initialize https://test.smartserver.space/f361e2be3bd4e39c74d7f68b56d033ddce131baf.js:247:6268
	_init.js/< https://test.smartserver.space/f361e2be3bd4e39c74d7f68b56d033ddce131baf.js:247:11285
	a https://test.smartserver.space/f361e2be3bd4e39c74d7f68b56d033ddce131baf.js:1:5282
	u https://test.smartserver.space/f361e2be3bd4e39c74d7f68b56d033ddce131baf.js:1:5370
TypeError: Swimlanes.findOne(...) is undefined[Learn More] f361e2be3bd4e39c74d7f68b56d033ddce131baf.js:289:153002
	addCard https://test.smartserver.space/f361e2be3bd4e39c74d7f68b56d033ddce131baf.js:289:153002
	u/t[n]/</< https://test.smartserver.space/f361e2be3bd4e39c74d7f68b56d033ddce131baf.js:217:6103
	f._withCurrentView https://test.smartserver.space/f361e2be3bd4e39c74d7f68b56d033ddce131baf.js:59:23097
	u/t[n]/< https://test.smartserver.space/f361e2be3bd4e39c74d7f68b56d033ddce131baf.js:217:6064
	e._withTemplateInstanceFunc https://test.smartserver.space/f361e2be3bd4e39c74d7f68b56d033ddce131baf.js:59:37698
	u/t[n] https://test.smartserver.space/f361e2be3bd4e39c74d7f68b56d033ddce131baf.js:217:6042
	i/</</</< https://test.smartserver.space/f361e2be3bd4e39c74d7f68b56d033ddce131baf.js:59:27013
	f._withCurrentView https://test.smartserver.space/f361e2be3bd4e39c74d7f68b56d033ddce131baf.js:59:23097
	i/</</< https://test.smartserver.space/f361e2be3bd4e39c74d7f68b56d033ddce131baf.js:59:26974
	a/this.delegatedHandler</< https://test.smartserver.space/f361e2be3bd4e39c74d7f68b56d033ddce131baf.js:59:9120
	dispatch https://test.smartserver.space/f361e2be3bd4e39c74d7f68b56d033ddce131baf.js:19:49877
	add/g.handle https://test.smartserver.space/f361e2be3bd4e39c74d7f68b56d033ddce131baf.js:19:46580
@andresmanelli

This comment has been minimized.

Copy link
Contributor

andresmanelli commented Feb 1, 2018

@gramakri I am getting myself errors of the kind There is no route [...]. Even when I load the main page.

For me, reloading a board gives errors, but going to the board from the home site works fine. This started happening after the Meteor update, I do not know if it is related.

@nebulade

This comment has been minimized.

Copy link
Contributor

nebulade commented Feb 1, 2018

I have pushed a pull request #1454 to fix the list view card moving. The details view is still not showing with this though, but at least the issue from @johnleeming showed in the screenshot should be gone.

@nebulade

This comment has been minimized.

Copy link
Contributor

nebulade commented Feb 1, 2018

I am not sure how the relationship in the ui is between the swimlanes view and the lists view, but swimlanes appears to be based off the lists view, however the lists view as it currently is, does not appear to have any reference to show the card details panel. Maybe someone with more knowledge here could explain where the lists view would ever show the details panel, since it misses the +cardDetails(currentCard) logic from the swimlanes.

@andresmanelli

This comment has been minimized.

Copy link
Contributor

andresmanelli commented Feb 1, 2018

@nebulade could you take a look at the last 3 commits of my fork? (See comments above). These bugs are fixed for me (maybe more tests are necessary) including the one fixed by your PR.

I think your commit maybe breaks the drag in swimlane view.

Sorry if maybe I'm mistaken, I'll give it a look later.

@nebulade

This comment has been minimized.

Copy link
Contributor

nebulade commented Feb 1, 2018

@andresmanelli ah nice, indeed I didn't look at all at your fork and was about to add similar changes for me, however given my poor code base knowledge as well as meteor knowledge, mine are just hacks ;-)

So I can confirm the three commits in your fork are fixing all those issues without side-effects I can make out. I think I will cherry-pick them for our Cloudron package to have a working app for our users. Thanks a lot, hope they get into mainline soon.

@xet7 xet7 closed this Feb 1, 2018

@xet7

This comment has been minimized.

Copy link
Member

xet7 commented Feb 1, 2018

Fixed in Wekan v0.69, I think

@johnleeming

This comment has been minimized.

Copy link

johnleeming commented Feb 1, 2018

seems to work fine for me - thanks very much.

I can change the order of cards in both list and swimlane views and also open card details in both views

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment