Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with root-url and Favicon #2094

Closed
letmp opened this issue Dec 6, 2018 · 6 comments
Closed

Problem with root-url and Favicon #2094

letmp opened this issue Dec 6, 2018 · 6 comments
Labels

Comments

@letmp
Copy link

letmp commented Dec 6, 2018

I installed wekan by following these instructions:
https://github.com/wekan/wekan-snap/wiki/Install
https://github.com/wekan/wekan/wiki/Nginx-Webserver-Config

I configured nginx to have wekan running at https://serverdomain/wekan
and I also set the root-url accordingly:
sudo snap set wekan root-url="https://serverdomain/wekan"

Everything is working fine except the favicon. Using the networkanalysis of firefox I can see that wekan-favicon.png is requested under "https://serverdomain/wekan-favicon.png" instead of "https://serverdomain/wekan/wekan-favicon.png"

@xet7 xet7 transferred this issue from wekan/wekan-snap Jan 6, 2019
@xet7 xet7 added the Bug label Jan 11, 2019
@xet7 xet7 added this to the 2019-02-28 Add/Remove/Bugs milestone Jan 11, 2019
@Meeques
Copy link

Meeques commented Jul 28, 2022

Hi @xet7 is this something you're still working on?
Kind regards!

@xet7 xet7 closed this as completed in 1b95f9f Jul 28, 2022
@xet7
Copy link
Member

xet7 commented Jul 28, 2022

@Meeques

I added some fix. Not tested yet, but it should work.

@xet7
Copy link
Member

xet7 commented Jul 28, 2022

In that fix, I removed / from URLs so that it would work with relative paths like https://serverdomain/wekan

@Meeques
Copy link

Meeques commented Jul 28, 2022

Thank you! I assume this is fixed in a Version after 6.09?

@xet7
Copy link
Member

xet7 commented Jul 28, 2022

This fix is not in any release yet, I would like to improve upgrade experience before releasing automatic updates etc #4423 (comment)

It's possible to test it now anyway: #4423 (comment)

@dsvk
Copy link

dsvk commented Aug 14, 2022

@xet7 1b95f9f has broken favicon loading on the boards themselves though. If you navigate to a board directly wihout having the favicon already cached then instead of loading wekan.example.com/favicon-16x16.png the browser tries to find it under wekan.example.com/b/[BOARD_ID]/favicon-16x16.png and despite being returned an HTTP 200 the favicon file is not actually there, it's just a fallback redirect to the board itself.

I imagine using an absolute path to the favicon automatically prepended by the admin-configured root URL would cover all cases (subdir installations, navigating to boards directly or both conditions combined).

@xet7 xet7 reopened this Aug 14, 2022
xet7 added a commit that referenced this issue Aug 14, 2022
…ns on subdomain URLs.

Thanks to dsvk and xet7 !

Related #2094
Emile840 pushed a commit to Emile840/wekan that referenced this issue Sep 21, 2022
…ns on subdomain URLs.

Thanks to dsvk and xet7 !

Related wekan#2094
@xet7 xet7 closed this as completed Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants