Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Feature: Copy many #1470

Merged
merged 20 commits into from Feb 15, 2018
Merged

New Feature: Copy many #1470

merged 20 commits into from Feb 15, 2018

Conversation

@erikturk
Copy link
Contributor

@erikturk erikturk commented Feb 8, 2018

I want to be able to add multiple cards from a list. We create a "template card" that has the appropriate checklists, and then make multiple copies of that card substituting the title and description from a user supplied list in json format.

I've added "Copy Multiple Cards" to the Hamburger menu for Cards.

When you paste a list like:

[ {"title": "First Card title", "description":"First Card Description"}, {"title":"Second Card Description","description":"Second Card Description"},{"title":"Last Card title","description":"Last Card description"}]

The menu option will create 3 new cards in the list that you select.

The commit includes i18n/en-GB.i18n.json - but shouldn't based on the contrib guidelines. removed in last commit

First time contributor. Feedback welcome (How do I get rid of the crazy/not useful/embarrassing commit messages that I used when developing this? Will they be part of the project forever?)


This change is Reviewable

@CLAassistant
Copy link

@CLAassistant CLAassistant commented Feb 8, 2018

CLA assistant check
All committers have signed the CLA.

@xet7
Copy link
Member

@xet7 xet7 commented Feb 8, 2018

@erikturk

Adding feature to Wekan is huge and excellent. There is nothing embarrassing, I also fix typos etc all the time.

Here's how to remove commits:
https://stackoverflow.com/questions/36168839/how-to-remove-commits-from-pull-request

Remove all changes to readme and changelog.

New strings are added in pull request to English base translation file wekan/i18n/en.i18n.json
Other translations are done at https://www.transifex.com/wekan/wekan/ , so remove other translations from pull request.

Thanks!

@erikturk
Copy link
Contributor Author

@erikturk erikturk commented Feb 8, 2018

Hi - thank you for your work in managing Wekan development. It was certainly very easy to find what to add and where.

My Travis-CI build is failing because of mentions of swimlanes. I know this is a new feature.

Am I building against an incorrect (or out of date) version of Wekan? What can I do to get my pull request to pass the Travis-CI check? Specific recommendations are appreciated (Don't do it for me, but please tell me what to do - I'm lost at this point, and would appreciate guidance.)

Thanks.

@xet7
Copy link
Member

@xet7 xet7 commented Feb 8, 2018

@erikturk

Travis is broken for everything, I have not fixed it yet. You don't need to change anything for Travis.

@xet7
Copy link
Member

@xet7 xet7 commented Feb 8, 2018

@erikturk

It seems that you are implementing Checklist Templates #904

Using this kind of JSON in wekan/i18n/en.i18n.json file and JSON validator like https://jsonlint to check for JSON errors:

        "copyManyCardPopup-title": "Copy Checklist Template to Many Cards",
        "copyManyCardPopup-title-instructions": "Destination Card Titles and Descriptions in this JSON format: [ {\"title\": \"First Card title\", \"description\":\"First Card Description\"}, {\"title\":\"Second Card Description\",\"description\":\"Second Card Description\"},{\"title\":\"Last Card title\",\"description\":\"Last Card description\"} ]",

Do the following:

  1. Rename everywhere in your added code variable names, translation variable names, and user visible texts: Copy Multiple Cards => Copy Checklist Template to Many Cards

  2. In below screenshot "Copy Checklist Template to Many Cards" popup change:

  • Copy Multiple Cards => Copy Checklist Template to Many Cards
  • Title: => Destination cards and titles in this JSON format:
  • Input box: Your example JSON text, like in screenshot below as pre-filled, and translatable like in wekan/i18n/en.i18n.json above

checklist-templates

@erikturk
Copy link
Contributor Author

@erikturk erikturk commented Feb 8, 2018

Thank you for this feedback! I'm excited to make these changes. You'll see an update soon!

@erikturk
Copy link
Contributor Author

@erikturk erikturk commented Feb 14, 2018

And, after 6 days of learning jade/pug, I think I've made the changes requested.

@xet7
Copy link
Member

@xet7 xet7 commented Feb 14, 2018

@erikturk

Thanks, I will test.

@xet7
Copy link
Member

@xet7 xet7 commented Feb 14, 2018

@erikturk

There is still variables with names like copyManyCard in translations etc. Those should be renamed to like "copyChecklistTemplateToManyCards" or similar. There should not be anything that has any text like copyManyCard, it's not clear enough.

@erikturk
Copy link
Contributor Author

@erikturk erikturk commented Feb 14, 2018

Thank you for the feedback. I'll get right on it

@erikturk
Copy link
Contributor Author

@erikturk erikturk commented Feb 15, 2018

Ready again for your review. Thank you for your patience and comments. Thank you for your efforts in coordinating wekan development.

@xet7
Copy link
Member

@xet7 xet7 commented Feb 15, 2018

@erikturk

Thanks a lot, now it's perfect ! I will merge it soon and release new version of Wekan with that feature. Developers like you are the worth gold and time well spent for me.

@xet7 xet7 merged commit cfaeb43 into wekan:devel Feb 15, 2018
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
license/cla Contributor License Agreement is signed.
Details
@erikturk erikturk deleted the erikturk:copyMany branch Feb 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants