Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new search feature #1503

Merged
merged 4 commits into from Feb 23, 2018
Merged

Add new search feature #1503

merged 4 commits into from Feb 23, 2018

Conversation

GhassenRjab
Copy link
Contributor

@GhassenRjab GhassenRjab commented Feb 23, 2018

This PR adds search feature ( related to #552 )

A new search button is added inside an opened board.
On clicking on it, the search sidebar will open and will show the input where to put the search keyword
and the last added ten cards by default.
After typing the keyword, the user has to press enter to start the search.
The matched cards will appear, and by clicking on them, they will open Inside the board.
To make the search as fast as possible, the keyword is matched against the cards' titles and descriptions and only a maximum of ten matches will be shown.


This change is Reviewable

@therampagerado
Copy link

Can we have settings where we can decide in how many cards to search? And also does it search in archived items?

@xet7
Copy link
Member

xet7 commented Feb 23, 2018

@therampagerado

You can add new feature request as new GitHub issue, and anyone can add pull request with code that adds those features, with possibility of admin to limit results to 10 or any other number of results, and enable searching of archived cards.

But those are not part of original specs at #552 , because returning much more results would really slow down everything when there is thousands of users. This pull request implements those original specs, and for that @GhassenRjab gets all of the bounty for this search feature. @GhassenRjab already spent more time than expected with implementing this feature, it was not easy.

@xet7 xet7 merged commit ab2884c into wekan:devel Feb 23, 2018
@xet7 xet7 added this to the v0.77 milestone Feb 23, 2018
@GhassenRjab GhassenRjab deleted the feature/search branch February 26, 2018 01:38
xet7 added a commit that referenced this pull request Dec 2, 2018
  Most likely armhf and arm64 does not build yet, I will add fixes later.

Thanks to xet7 !

Related #1503,
related wekan/wekan-snap#46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants