Allow setting custom kubernetes labels when using the helm chart #4031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wasn't sure whether to bump the chart version as part of this PR, or if you have a separate procedure for doing that. Please let me know if I should add that version change here. |
|
I bump versions when releasing new Wekan version. PRs do not include version number changes. |
That's good. Thanks for merging, and for the new release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds two helm values to the helm chart, for setting custom kubernetes labels on the
Deploymentobject, and on thePods created by the deployment.We need this when using the backup system velero, to specify which components need to be restored.
This change is