Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Replace CollectionFS with meteor-file-collection #875
The library currently used by Wekan for attachments (CollectionFS) is not very actively maintained, having been deprecated for most of 2016. It's also somewhat extensive in its feature set, of which Wekan uses only a fraction but is burdened by bugs resulting from said complexity. So I'm here proposing to replace it with meteor-file-collection, which has mostly the same interfaces as CollectionFS and also uses GridFS for storage.
In addition to being simpler and more secure, the built-in resumable.js integration will enable simultaneous upload of multiple files, as well as drag-and-drop for attachment upload.
The particular CollectionFS bug that I hit that prompted its replacement was its inability to deal well with local uploads, a part of a custom import job that I needed to get to work.
This is a work-in-progress, so should not be merged until the following are all done:
At the moment, using missing features result in console warnings with the prefix
I think this can be merged when it automatically detects CollectionFS attachments and converts them to meteor-file-collection. On some platforms like Sandstorm where Wekan code is signed and read-only, it's not possible to run separate migration scripts.
Sorry, looks like I don't have the time I expected to have to work on Wekan stuff. The "Allow edits from maintainers" tag is set on this, so at least @xet7 should have push rights to the source branch in our fork. I'm also ok with someone else starting a new PR based on this, using their own fork.