New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace CollectionFS with meteor-file-collection #875

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
3 participants
@eemeli
Copy link

eemeli commented Feb 27, 2017

The library currently used by Wekan for attachments (CollectionFS) is not very actively maintained, having been deprecated for most of 2016. It's also somewhat extensive in its feature set, of which Wekan uses only a fraction but is burdened by bugs resulting from said complexity. So I'm here proposing to replace it with meteor-file-collection, which has mostly the same interfaces as CollectionFS and also uses GridFS for storage.

In addition to being simpler and more secure, the built-in resumable.js integration will enable simultaneous upload of multiple files, as well as drag-and-drop for attachment upload.

The particular CollectionFS bug that I hit that prompted its replacement was its inability to deal well with local uploads, a part of a custom import job that I needed to get to work.

This is a work-in-progress, so should not be merged until the following are all done:

  • Basic attachment upload/download/delete support
  • Avatar upload support
  • Drag-and-drop for attachment upload (#300)
  • Upload progress indicator
  • Better fix for opening non-image attachments (#99)
  • Re-enabling attachment import
  • Migration script from CollectionFS

At the moment, using missing features result in console warnings with the prefix [re-attach].

In addition to the above, other issues that would probably get resolved by this include: #142, #386, #544, #698, #784, CollectionFS/Meteor-CollectionFS#449.


This change is Reviewable

Replace CollectionFS with meteor-file-collection
Avatars & import are not yet functional. Using missing features
result in console warnings with the prefix [re-attach].
@xet7

This comment has been minimized.

Copy link
Member

xet7 commented Feb 27, 2017

@eemeli

Thanks!

I think this can be merged when it automatically detects CollectionFS attachments and converts them to meteor-file-collection. On some platforms like Sandstorm where Wekan code is signed and read-only, it's not possible to run separate migration scripts.

@GhassenRjab

This comment has been minimized.

Copy link
Contributor

GhassenRjab commented Jul 11, 2017

Can other developers join and contribute to this PR? If yes, how?

@eemeli

This comment has been minimized.

Copy link
Author

eemeli commented Jul 17, 2017

Sorry, looks like I don't have the time I expected to have to work on Wekan stuff. The "Allow edits from maintainers" tag is set on this, so at least @xet7 should have push rights to the source branch in our fork. I'm also ok with someone else starting a new PR based on this, using their own fork.

@xet7 xet7 added this to PR: Needs fixing, not ready yet in Wekan Roadmap Nov 22, 2017

@xet7 xet7 removed this from PR: Needs fixing, not ready yet in Wekan Roadmap Jun 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment