Catch obscure inner exceptions from xml serializer and continue

welaika · Jun 14, 2011 · 2e4df5c · 2e4df5c
1 parent 26b9229
commit 2e4df5c
Showing 1 changed file with 19 additions and 16 deletions.
diff --git a/src/com/loopj/android/hoptoad/HoptoadNotifier.java b/src/com/loopj/android/hoptoad/HoptoadNotifier.java
@@ -212,22 +212,25 @@ private static void writeExceptionToDisk(Throwable e) {
             s.startTag("", "backtrace");
             Throwable currentEx = e;
             while(currentEx != null) {
-                StackTraceElement[] stackTrace = currentEx.getStackTrace();
-                for(StackTraceElement el : stackTrace) {
-                    s.startTag("", "line");
-                    s.attribute("", "method", el.getClassName() + "." + el.getMethodName());
-                    s.attribute("", "file", el.getFileName());
-                    s.attribute("", "number", String.valueOf(el.getLineNumber()));
-                    s.endTag("", "line");
-                }
-
-                currentEx = currentEx.getCause();
-                if(currentEx != null) {
-                    s.startTag("", "line");
-                    s.attribute("", "file", "### CAUSED BY ###: " + currentEx.toString());
-                    s.attribute("", "number", "");
-                    s.endTag("", "line");
-                }
+                // Catch some inner exceptions without discarding the entire report
+                try {
+                    StackTraceElement[] stackTrace = currentEx.getStackTrace();
+                    for(StackTraceElement el : stackTrace) {
+                        s.startTag("", "line");
+                        s.attribute("", "method", el.getClassName() + "." + el.getMethodName());
+                        s.attribute("", "file", el.getFileName());
+                        s.attribute("", "number", String.valueOf(el.getLineNumber()));
+                        s.endTag("", "line");
+                    }
+
+                    currentEx = currentEx.getCause();
+                    if(currentEx != null) {
+                        s.startTag("", "line");
+                        s.attribute("", "file", "### CAUSED BY ###: " + currentEx.toString());
+                        s.attribute("", "number", "");
+                        s.endTag("", "line");
+                    }
+                } catch(Throwable innerException) {}
             }
             s.endTag("", "backtrace");
             s.endTag("", "error");