fix require plugin path #141

Closed
matjack1 opened this Issue Jun 5, 2013 · 5 comments

Comments

Projects
None yet
3 participants
@matjack1
Contributor

matjack1 commented Jun 5, 2013

sorry for being late on the #139 but we'd change the

return self::join_paths(WP_CONTENT, 'plugins', 'wordless')

with

return self::join_paths(plugin_dir_path(__FILE__))

so we can decouple the plugin path from the code. It has to be tested though.

@ghost ghost assigned pioneerskies Jun 5, 2013

@pioneerskies

This comment has been minimized.

Show comment
Hide comment
@pioneerskies

pioneerskies Jun 6, 2013

Member

I think you'd want to say

return plugin_dir_path(__FILE__)

even to test if __FILE__ is the right choice or if wordless.php would be.

Isn't it?

Member

pioneerskies commented Jun 6, 2013

I think you'd want to say

return plugin_dir_path(__FILE__)

even to test if __FILE__ is the right choice or if wordless.php would be.

Isn't it?

@pioneerskies

This comment has been minimized.

Show comment
Hide comment
@pioneerskies

pioneerskies Jun 14, 2013

Member

Bump @matjack1

Member

pioneerskies commented Jun 14, 2013

Bump @matjack1

@matjack1

This comment has been minimized.

Show comment
Hide comment
@matjack1

matjack1 Jun 17, 2013

Contributor

sorry, missed your reply!

i think that FILE IS wordless.php, since the wordless.php file will require everything else, we still have to try

Contributor

matjack1 commented Jun 17, 2013

sorry, missed your reply!

i think that FILE IS wordless.php, since the wordless.php file will require everything else, we still have to try

@delphaber

This comment has been minimized.

Show comment
Hide comment
@delphaber

delphaber Oct 9, 2014

Member

So.. I've decided to remove plugin_path because was unused.

Member

delphaber commented Oct 9, 2014

So.. I've decided to remove plugin_path because was unused.

@delphaber delphaber closed this Oct 9, 2014

@matjack1

This comment has been minimized.

Show comment
Hide comment
@matjack1

matjack1 Oct 10, 2014

Contributor

🔫

Contributor

matjack1 commented Oct 10, 2014

🔫

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment