Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WELD-1991 Fix invocation of overloaded method on decorator #1070

Closed
wants to merge 2 commits into from

Conversation

mkouba
Copy link
Member

@mkouba mkouba commented Jul 14, 2015

No description provided.

@weld-tester
Copy link

Triggering build using a merge of 952528b on branch master:
Private: https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/Weld-2.x-pull-player-executor-osprey/

@weld-tester
Copy link

Build 918 is now running using a merge of 952528b on branch master:
Private: https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/Weld-2.x-pull-player-executor-osprey/918

@weld-tester
Copy link

return matching.get(0);
}
// Choose the most specific method
// This does meet all requirements of JLS but it should work in most cases
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not fully understand the comment. Perhaps it is wrong? If this code meets all the JLS requirements then it should work in all (not most) cases, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not is missing. I'll fix the comment.

@weld-tester
Copy link

@weld-tester
Copy link

Triggering build using a merge of e3d6be6 on branch master:
Private: https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/Weld-2.x-pull-player-executor-osprey/

@weld-tester
Copy link

Build 940 is now running using a merge of e3d6be6 on branch master:
Private: https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/Weld-2.x-pull-player-executor-osprey/940

@jharting
Copy link
Member

Merged, thanks!

@jharting jharting closed this Jul 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants