Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docker container socket issue. #83

Merged
merged 1 commit into from Jul 3, 2018
Merged

Fix docker container socket issue. #83

merged 1 commit into from Jul 3, 2018

Conversation

henrywang
Copy link
Contributor

  1. The bdcs-api docker image is able to work with domain socket.

@henrywang
Fix docker container socket issue.
5c67cb4 
1. The bdcs-api docker image is able to work with domain socket.
atodorov
atodorov reviewed Jul 3, 2018
View reviewed changes
entrypoint.sh
@@ -4,4 +4,5 @@ STORE=$(realpath /mddb/"${STORE:-cs.repo}")
MDDB="/mddb/${MDDB:-metadata.db}"
RECIPES="${RECIPES:-/recipes/}"

/usr/local/bin/bdcs-api-server --bdcs "$STORE" "$MDDB" "$RECIPES"
mkdir -p /run/weldr
/usr/local/bin/bdcs-api-server -s /run/weldr/api.socket -g root --bdcs "$STORE" "$MDDB" "$RECIPES"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the idea here? To expose this directory to the host system (or via shared volume) and then make that available to welder-web ?

Copy link
Contributor Author

@henrywang henrywang Jul 3, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@atodorov, Expose to a shared volume, then both welder-web and end to end test container can work with it.
PS, The end to end test container needs API to wait for the backend to become ready before test running.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 162

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 69.73%
Totals Coverage Status
Change from base Build 160: 0.0%
Covered Lines: 1578
Relevant Lines: 2263
💛 - Coveralls

@henrywang henrywang merged commit 3a119f6 into weldr:master Jul 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atodorov atodorov atodorov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@henrywang @coveralls @atodorov