Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for becoming an official hackage module. #19

Merged
merged 9 commits into from Jun 30, 2017

Conversation

@clumens
Copy link
Contributor

commented Jun 29, 2017

Steps after this include renaming the github repo to codec-rpm, uploading to hackage as a test build, uploading to hackage officially, and removing the haskell-rpm subtree from the bdcs repo and updating its build requirements.

clumens added 7 commits Jun 29, 2017
This seems to be more in line with other similar Haskell modules.
These are better off as examples of how to use the library than as
system-installed programs.  This also decreases the package requirements
a bit.
This makes it very likely the package will just randomly break one day
in the future when ghc changes.  We'll still see the messages this way,
it just won't break the build.
According to https://pvp.haskell.org/, this is something I should be
doing.
There's already an rpm module, though it has not been updated in quite
some time.  I've also knocked our version number back down to 0.1.  It
was only at 1 to avoid conflicts with that other module while this was
a subtree of bdcs.  That's not going to be the case any longer, and we
never did an actual tagged release of this module anyway.  So it
shouldn't interfere with anything.

I'll be renaming the source repo on github to match, which I am hoping
means it gets checked out into a renamed directory.
Copy link

left a comment

Looks good to me other than these 2 URLs

description: This module provides a library for reading RPM files and converting them
into useful data structures. There is currently no way to operate in
reverse - that is, for building an RPM file out of a data structure.
homepage: https://github.com/weldr/haskell-rpm

This comment has been minimized.


source-repository head
type: git
location: https://github.com/weldr/haskell-rpm

This comment has been minimized.

clumens added 2 commits Jun 30, 2017
This reverts commit 5e611ca.  It is no
longer needed now that the programs are not being built anymore.
@coveralls

This comment has been minimized.

Copy link

commented Jun 30, 2017

Coverage Status

Coverage decreased (-1.5%) to 97.279% when pulling 6abc94f on clumens:module into 5e611ca on weldr:master.

@clumens clumens merged commit 61e3456 into weldr:master Jun 30, 2017
1 of 2 checks passed
1 of 2 checks passed
coverage/coveralls Coverage decreased (-1.5%) to 97.279%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.