Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IGNORE] [test] Modify function return type #39

Open
wants to merge 1 commit into
base: master
from

Conversation

@atodorov
Copy link
Member

@atodorov atodorov commented Jul 5, 2018

this should pass all unit tests but cause bdcs build to fail

@clumens
Copy link
Contributor

@clumens clumens commented Jul 5, 2018

Just in case you missed this in IRC, I think you forgot the last part of my patch. It would have been easy to lose it. You also need to remove the last line of payloadContentsC - that is, the .| readCPIO bit.

this should pass all unit tests but cause bdcs build to fail
@atodorov atodorov force-pushed the atodorov:intentionally_break_bdcs branch from dabc193 to b00c923 Jul 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants