Use grub2 for BIOS boot support instead of syslinux #1226
Conversation
Pull Request Test Coverage Report for Build 2423689840
💛 - Coveralls |
| %if domacboot: | ||
| ${make_efiboot("images/macboot.img", imgtype="apple")} | ||
| %endif | ||
|
|
There was a problem hiding this comment.
Why is this being removed? Wouldn't this eliminate the fancy integration with Intel Mac EFI firmware?
There was a problem hiding this comment.
That is, without this, we don't get in the Mac EFI menu the fancy "Fedora" icon that makes it obvious what we are to the firmware when booting the stick. I would prefer we keep this.
There was a problem hiding this comment.
+1 to @Conan-Kudo 's question here. It doesn't seem necessary to remove the integration with the intel mac efi firmware.
There was a problem hiding this comment.
Because, at least in my testing, it isn't needed. And I like things to be as simple as possible. It's not too hard to tell what it is when booting, even without the logo.
There was a problem hiding this comment.
Does it work when the plist and logo files are installed in the regular ESP image?
There was a problem hiding this comment.
No idea, but I would guess not. IIRC plist neeed to be 'blessed' in order for it to be loaded. There are so many variations to all these things that I'm not going to explore all of them just to get a logo on there.
There was a problem hiding this comment.
Ahh, yeah, so grub2-macbless only works with HFS+ ESP, rather than FAT32 ESP.
There was a problem hiding this comment.
I'm not actually sure if removing this will break on my 2009 MacBook Pro (which I use as a Linux laptop), I will need to test this... Last I tried it only showed me stuff with the HFS+ ESP...
There was a problem hiding this comment.
Yeah, confirmed, my 2009 MBP isn't super-happy with the FAT ESP...
bcl
force-pushed
the
master-replace-syslinux
branch
from
ce9edf5
to
fd9b5f2
Compare
|
So just scanning this briefly - does this ultimately require us to boot via BIOS from a GPT-labelled disk? Because we did try doing that for Fedora installs for one release, and found enough systems that refused to do that that we reverted it. That was some time ago, and of course a lot of systems were fine with it. So we might consider that a small enough problem to live with. Just wanted to flag it up. |
|
It shouldn't require GPT on BIOS boot, but I am preparing a separate Change proposal for doing that. |
No, this only effects the boot.iso boot process. |
syslinux is unsupported and is going to be removed from Fedora. This removes it and all of its configuration files from the templates.
This adds support for BIOS booting using grub2. The bios config file and grub2 modules are under /boot/grub2/
Apple hardware doesn't need the macboot.img to boot, efiboot.img is not needed in the filesystem so do not graft it into it. Remove macboot.img and apple specific EFI support
Just add them to the xorrisofs command, the order of the arguments is interleaved and trying to assemble it from variables just makes it more confusing.
bcl
force-pushed
the
master-replace-syslinux
branch
from
7cba475
to
b0a5096
Compare
No description provided.