lorax-composer: Handle packages with multiple builds #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashea
approved these changes
Dec 6, 2018
Anaconda is currently not able to handle cdn repo urls in the kickstart. Add a new function that checks for extra repos and returns True. Related: rhbz#1655623
This will block starting a compose if the sources only reference cdn.redhat.com urls. Resolves: rhbz#1655623
And in an intermediate version it returns a VectorString object which isn't serializable by the json or toml modules. So convert it to a list so that the type is consistent in the sources code. (cherry picked from commit e9e5139) Resolves: rhbz#1655876
Stop using fake dnf object, use the real thing. This will help catch problems with dnf returning unexpected types like VectorString. (cherry picked from commit 27aff75) Related: rhbz#1655876
Depending on which version of dnf is installed it may return a tuple, or may return a list. Work around this by only comparing the 1st element of it. Related: rhbz#1655876
When the repository has multiple arches, eg. i686 and x86_64, it should add a new entry to the project's builds list, not create a new project in the list. This handles that by adding a modified insort_left function and examining the packages returned from dnf to make sure they aren't already listed in the results. It also handles adding them in sorted order so that no further sorting needs to be done on the results. Resolves: rhbz#1656642
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the repository has multiple arches, eg. i686 and x86_64, it should
add a new entry to the project's builds list, not create a new project
in the list.
This handles that by adding a modified insort_left function and
examining the packages returned from dnf to make sure they aren't
already listed in the results. It also handles adding them in sorted
order so that no further sorting needs to be done on the results.
Resolves: rhbz#1656642