Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass dnf's ssl options to anaconda to enable RHEL subscription content #561

Merged
merged 2 commits into from Feb 12, 2019

Conversation

larskarlitski
Copy link
Contributor

This makes the reposync workaround unnecessary when creating images from RHEL systems.

See individual commits for explanation.

Depends on pykickstart/pykickstart#250 and https://github.com/rhinstaller/anaconda/pull/1745/files

Before merging, let's

  • figure out if we can talk to subscription-manager without being root

Copy link
Contributor

@bcl bcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just need to cherry-pick the rhel8 commit.

@@ -240,10 +240,11 @@ if __name__ == '__main__':

start_queue_monitor(server.config["COMPOSER_CFG"], uid, gid)

# Drop root privileges on the main process
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should just cherry-pick over the rhel8 commit dbc4d08

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah that's much better. Done.

@atodorov
Copy link
Member

atodorov commented Jan 8, 2019

@larskarlitski tests failing with

2019-01-08 13:34:45,882: Non interactive installation failed: Problems in request:
2019-01-08 13:34:45,882: missing packages: krb5-libs-1.16.1-23.fc29.x86_64.

I can't find kerberos or krb5-libs defined in the blueprints so something must be pulling that as a dependency. Not sure if we need to bump the version somewhere in the code or package is missing on the mirrors.

@larskarlitski
Copy link
Contributor Author

I can't find kerberos or krb5-libs defined in the blueprints so something must be pulling that as a dependency. Not sure if we need to bump the version somewhere in the code or package is missing on the mirrors.

I don't think these changes pull those in. The only difference is the version bump for pykickstart.

By the way, that version of pykickstart hasn't been released yet. We should probably wait with merging this.

@wzzrd
Copy link

wzzrd commented Jan 20, 2019

Tried this out after talking to Lars last Friday, and this patch works for me.

Copy link
Contributor

@bcl bcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! And yes, we need to make sure to wait for the new version of pykickstart first :)

larskarlitski and others added 2 commits January 30, 2019 16:33
If a repository has `sslcacert`, `sslclientcert`, or `ssclientkey` set,
pass them to anaconda through the kickstart file. This is mostly the
case when using RHEL repositories that are accessed through a
subscription.
We need to be root to read the certificates that give access to the
package repos.  Right now, the alternative seems to be changing
permissions on the certs themselves, which seems less good.  We're
running anaconda as root anyway.
@larskarlitski
Copy link
Contributor Author

The pykickstart change landed in 3.19. I've updated the spec file to reflect that and rebased on master. I think this is ready to go.

@bcl
Copy link
Contributor

bcl commented Jan 30, 2019

Thanks, I think we need to wait for pykickstart to hit the repos first, otherwise installing it will fail. It isn't on dl.fedoraproject.org yet.

@bcl bcl merged commit 022e9eb into weldr:master Feb 12, 2019
@bcl
Copy link
Contributor

bcl commented Feb 12, 2019

pykickstart 3.20 is in rawhide, merging this onto master.

@larskarlitski larskarlitski deleted the cdn branch May 23, 2019 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants