New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for lorax-composer on other arches #616
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have uninstalled xorriso from the test system. I have genisoimage which provides mkisofs: |
|
There's some missing output there, probably captured in program.log I can't tell why it failed from just the error code. Also, I copied that over from the rhel8 template, so it really should work... |
|
with the latest changes I was able to build live-iso on ppc and boot the results with kvm. |
Some platforms do not have grub2, and some require other partitions. Anaconda will add platform specific partitions if the 'reqpart' command is included, and it will add bootloader specific packages to the list if they are needed. Related: rhbz#1673744
This is complicated by the fact that much of this module requires mount. So for now just test the things that don't need mount. Related: rhbz#1673744
Add a /.in-container file to the container root so that tests requiring root and loop device support will be skipped when running in a container. Related: rhbz#1673744
This also moves the run_creator kickstart checks into check_kickstart so that tests may be added. Related: rhbz#1673744
Related: rhbz#1673744
Apparently nobody has used these since the switch to py3, xrange is now range and it needs to read the file in binary mode when generating the sha256. Related: rhbz#1673744
reqpart can be used to make kickstarts more platform agnostic, creating needed partitions without lmc having to keep track of the arch-specific needs. eg. ppc64 needs prepboot and /boot This increases the size of the disk based on whether reqpart or reqpart --add-boot is in the kickstart. Note that this is only valid for partitioned disk output types, not for filesystem images or live iso output. Related: rhbz#1673744
Some platforms, like ppc64, require that the /boot partition be present. It doesn't hurt to have it there on other platforms so instead of trying to add per-arch kickstart templates just use reqpart --add-boot everywhere. Related: rhbz#1673744
This will make it easier to add a new subclass that only handles installpkg for use with livemedia-creator and lorax-composer iso creation. Related: rhbz#1673744
This template runner only uses the installpkg command to gather a list of package NEVRA to be installed to support live iso creation. Related: rhbz#1673744
If a package is excluded in the template and later added by a blueprint or dependency, anaconda will fail to finish the installation. So remove the -dracut-config-rescue exclusion and instead remove the rescue artifacts in %post Related: rhbz#1673744
In order to support iso creation on multiple arches with the templates we need to be able to select different packages based on arch. lorax-composer uses the arch-specific Lorax templates in order to generate the output iso so this patch: 1. Creates a new template and type to parse it, live-install.tmpl which contains only installpkg commands and #if clauses for arch 2. Removes bootloader related packages from the live-iso.ks 3. Remove dracut-config-rescue exclusion because it can cause problems with some blueprints. 4. Switch logo requirement to system-logos which is satisfied by generic-logos or fedora-logos. This prevents conflicts when a blueprint installs fedora-release-workstation. So in the future, if x86.tmpl, etc. need a new package to support creating the iso it should be added to the correct section in ./share/live/live-install.tmpl Resolves: rhbz#1673744
Related: rhbz#1673744
Pull Request Test Coverage Report for Build 1375
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a port of PR #603, including a few extra patches to support easier cherry-picking and tests.
--- Merge policy ---
*-aws-runtestPASS*-azure-runtestPASS*-images-runtestPASS*-openstack-runtestPASS*-vmware-runtestPASSrhel8-*andrhel7-*branches commit log references an approvedbug in Bugzilla. Do not merge if the bug doesn't have the 3 ACKs set to
+!--- Jenkins commands ---
ok to testto accept this pull request for testingtest this pleasefor a one time test runretest this pleaseto start a new build