Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new compose type for Hyper-V #671

Merged
merged 1 commit into from Apr 3, 2019
Merged

Add a new compose type for Hyper-V #671

merged 1 commit into from Apr 3, 2019

Conversation

dashea
Copy link
Contributor

@dashea dashea commented Apr 2, 2019

This is based on the VHD compose type, with the following differences:

  • Use the vhdx format instead of vhd
  • No WALinuxAgent
  • Install hyperv-daemons

The hyperv-daemons are activated through udev rules, so there is no need
to add them to the services line.

--- Description of proposed changes ---

--- Merge policy ---

  • Travis CI PASS
  • *-aws-runtest PASS
  • *-azure-runtest PASS
  • *-images-runtest PASS
  • *-openstack-runtest PASS
  • *-vmware-runtest PASS
  • For rhel8-* and rhel7-* branches commit log references an approved
    bug in Bugzilla. Do not merge if the bug doesn't have the 3 ACKs set to +!

--- Jenkins commands ---

  • ok to test to accept this pull request for testing
  • test this please for a one time test run
  • retest this please to start a new build

@coveralls
Copy link

coveralls commented Apr 2, 2019

Pull Request Test Coverage Report for Build 1440

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 57.424%

Totals Coverage Status
Change from base Build 1436: 0.0%
Covered Lines: 2895
Relevant Lines: 4854

💛 - Coveralls

Copy link
Contributor

@bcl bcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just that one comment.

src/pylorax/api/compose.py Show resolved Hide resolved
src/pylorax/api/compose.py Outdated Show resolved Hide resolved
This is based on the VHD compose type, with the following differences:

  * Use the vhdx format instead of vhd
  * No WALinuxAgent
  * Install hyperv-daemons

The hyperv-daemons are activated through udev rules, so there is no need
to add them to the services line.
Copy link
Contributor

@bcl bcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AckAck

@dashea dashea merged commit 434fe58 into weldr:master Apr 3, 2019
@dashea dashea deleted the hyper-v branch April 25, 2019 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants